Skip to content

Conversation

@david-crespo
Copy link
Collaborator

There was an existing race condition in our instance create nav blocking code that was revealed by RHF 7.48.0. @charliepark and I are not sure what changed that caused it to be a problem, but it's a good opportunity to fix it regardless. See the RHF diff at 7.47.0...7.48.0.

We're going to wait until after the release to merge this because we want to give it extra time to bake.

@vercel
Copy link

vercel bot commented Feb 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
console ✅ Ready (Inspect) Visit Preview Feb 7, 2024 8:25pm

@david-crespo david-crespo marked this pull request as ready for review February 7, 2024 20:22
@david-crespo
Copy link
Collaborator Author

I was curious how it handles server errors, as in, would isSubmitSuccessful stay false, or does it always turn true when the submit ends? Looks like it does the right thing, so it is looking at whether our async function resolves or rejects.

image

@david-crespo david-crespo merged commit 3dd635a into main Feb 8, 2024
@david-crespo david-crespo deleted the instance-create-block branch February 8, 2024 01:45
david-crespo added a commit to oxidecomputer/omicron that referenced this pull request Feb 14, 2024
oxidecomputer/console@e5a1f80...1f8ebf2

* [1f8ebf28](oxidecomputer/console@1f8ebf28) oxidecomputer/console#1958
* [b454cefd](oxidecomputer/console@b454cefd) oxidecomputer/console#1955
* [1ce32d32](oxidecomputer/console@1ce32d32) oxidecomputer/console#1956
* [794ae11d](oxidecomputer/console@794ae11d) oxidecomputer/console#1952
* [903b8f6a](oxidecomputer/console@903b8f6a) tweak api-diff: fix type error on first arg, use dax's new built-in pipe
* [a4e15cdd](oxidecomputer/console@a4e15cdd) oxidecomputer/console#1950
* [32037d40](oxidecomputer/console@32037d40) oxidecomputer/console#1949
* [f02678b0](oxidecomputer/console@f02678b0) vite 5.1
* [1936e0d8](oxidecomputer/console@1936e0d8) oxidecomputer/console#1948
* [cfda1636](oxidecomputer/console@cfda1636) forgot to bump mockServiceWorker.js (no actual changes)
* [4792105e](oxidecomputer/console@4792105e) oxidecomputer/console#1943
* [a26db9ea](oxidecomputer/console@a26db9ea) upgrade date-fns thru major version, update calls accordingly
* [3dd635a6](oxidecomputer/console@3dd635a6) oxidecomputer/console#1933
* [6c8f7a9c](oxidecomputer/console@6c8f7a9c) upgrade filesize through a major version
* [8f641b97](oxidecomputer/console@8f641b97) remove blathering in readme about node 16, which is EOL
* [e9d157a1](oxidecomputer/console@e9d157a1) do ladle too—oh my god why does it have 3000 lines in the lockfile
* [e1cdcc13](oxidecomputer/console@e1cdcc13) oxidecomputer/console#1941
* [76877ffb](oxidecomputer/console@76877ffb) oxidecomputer/console#1938
david-crespo added a commit to oxidecomputer/omicron that referenced this pull request Feb 23, 2024
oxidecomputer/console@e5a1f80...80f1167

* [80f11673](oxidecomputer/console@80f11673) oxidecomputer/console#1957
* [5d989a70](oxidecomputer/console@5d989a70) oxidecomputer/console#1959
* [d4ec1927](oxidecomputer/console@d4ec1927) turn off license-eye comments, I hate them. CI failure is sufficient
* [f8d2f36e](oxidecomputer/console@f8d2f36e) oxidecomputer/console#1960
* [e0b676dc](oxidecomputer/console@e0b676dc) upgrade husky commands for v9 https://github.com/typicode/husky/releases/tag/v9.0.1
* [f31d5331](oxidecomputer/console@f31d5331) oxidecomputer/console#1944
* [b4552eea](oxidecomputer/console@b4552eea) Revert "Revert all app changes since v6 except two small fixes (oxidecomputer/console#1958)"
* [1f8ebf28](oxidecomputer/console@1f8ebf28) oxidecomputer/console#1958
* [b454cefd](oxidecomputer/console@b454cefd) oxidecomputer/console#1955
* [1ce32d32](oxidecomputer/console@1ce32d32) oxidecomputer/console#1956
* [794ae11d](oxidecomputer/console@794ae11d) oxidecomputer/console#1952
* [903b8f6a](oxidecomputer/console@903b8f6a) tweak api-diff: fix type error on first arg, use dax's new built-in pipe
* [a4e15cdd](oxidecomputer/console@a4e15cdd) oxidecomputer/console#1950
* [32037d40](oxidecomputer/console@32037d40) oxidecomputer/console#1949
* [f02678b0](oxidecomputer/console@f02678b0) vite 5.1
* [1936e0d8](oxidecomputer/console@1936e0d8) oxidecomputer/console#1948
* [cfda1636](oxidecomputer/console@cfda1636) forgot to bump mockServiceWorker.js (no actual changes)
* [4792105e](oxidecomputer/console@4792105e) oxidecomputer/console#1943
* [a26db9ea](oxidecomputer/console@a26db9ea) upgrade date-fns thru major version, update calls accordingly
* [3dd635a6](oxidecomputer/console@3dd635a6) oxidecomputer/console#1933
* [6c8f7a9c](oxidecomputer/console@6c8f7a9c) upgrade filesize through a major version
* [8f641b97](oxidecomputer/console@8f641b97) remove blathering in readme about node 16, which is EOL
* [e9d157a1](oxidecomputer/console@e9d157a1) do ladle too—oh my god why does it have 3000 lines in the lockfile
* [e1cdcc13](oxidecomputer/console@e1cdcc13) oxidecomputer/console#1941
* [76877ffb](oxidecomputer/console@76877ffb) oxidecomputer/console#1938
david-crespo added a commit to oxidecomputer/omicron that referenced this pull request Feb 26, 2024
### User-facing changes

* [80f11673](oxidecomputer/console@80f11673)
oxidecomputer/console#1957
* [f31d5331](oxidecomputer/console@f31d5331)
oxidecomputer/console#1944
* [b454cefd](oxidecomputer/console@b454cefd)
oxidecomputer/console#1955
* [1936e0d8](oxidecomputer/console@1936e0d8)
oxidecomputer/console#1948

---

### All changes

oxidecomputer/console@e5a1f80...80f1167

* [80f11673](oxidecomputer/console@80f11673)
oxidecomputer/console#1957
* [5d989a70](oxidecomputer/console@5d989a70)
oxidecomputer/console#1959
* [d4ec1927](oxidecomputer/console@d4ec1927)
turn off license-eye comments, I hate them. CI failure is sufficient
* [f8d2f36e](oxidecomputer/console@f8d2f36e)
oxidecomputer/console#1960
* [e0b676dc](oxidecomputer/console@e0b676dc)
upgrade husky commands for v9
https://github.com/typicode/husky/releases/tag/v9.0.1
* [f31d5331](oxidecomputer/console@f31d5331)
oxidecomputer/console#1944
* [b4552eea](oxidecomputer/console@b4552eea)
Revert "Revert all app changes since v6 except two small fixes
(oxidecomputer/console#1958)"
* [1f8ebf28](oxidecomputer/console@1f8ebf28)
oxidecomputer/console#1958
* [b454cefd](oxidecomputer/console@b454cefd)
oxidecomputer/console#1955
* [1ce32d32](oxidecomputer/console@1ce32d32)
oxidecomputer/console#1956
* [794ae11d](oxidecomputer/console@794ae11d)
oxidecomputer/console#1952
* [903b8f6a](oxidecomputer/console@903b8f6a)
tweak api-diff: fix type error on first arg, use dax's new built-in pipe
* [a4e15cdd](oxidecomputer/console@a4e15cdd)
oxidecomputer/console#1950
* [32037d40](oxidecomputer/console@32037d40)
oxidecomputer/console#1949
* [f02678b0](oxidecomputer/console@f02678b0)
vite 5.1
* [1936e0d8](oxidecomputer/console@1936e0d8)
oxidecomputer/console#1948
* [cfda1636](oxidecomputer/console@cfda1636)
forgot to bump mockServiceWorker.js (no actual changes)
* [4792105e](oxidecomputer/console@4792105e)
oxidecomputer/console#1943
* [a26db9ea](oxidecomputer/console@a26db9ea)
upgrade date-fns thru major version, update calls accordingly
* [3dd635a6](oxidecomputer/console@3dd635a6)
oxidecomputer/console#1933
* [6c8f7a9c](oxidecomputer/console@6c8f7a9c)
upgrade filesize through a major version
* [8f641b97](oxidecomputer/console@8f641b97)
remove blathering in readme about node 16, which is EOL
* [e9d157a1](oxidecomputer/console@e9d157a1)
do ladle too—oh my god why does it have 3000 lines in the lockfile
* [e1cdcc13](oxidecomputer/console@e1cdcc13)
oxidecomputer/console#1941
* [76877ffb](oxidecomputer/console@76877ffb)
oxidecomputer/console#1938
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants