Add copy-to-clipboard to External IPs table on networking tab #2313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
approved these changes
Jul 16, 2024
Collaborator
david-crespo
left a comment
david-crespo
left a comment
There was a problem hiding this comment.
I like it. I thought it might feel cluttered, but the buttons totally blend in.
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Jul 17, 2024
oxidecomputer/console@4377d01...17ae890 * [17ae890c](oxidecomputer/console@17ae890c) oxidecomputer/console#2331 * [3a25f287](oxidecomputer/console@3a25f287) oxidecomputer/console#2330 * [d7e92f65](oxidecomputer/console@d7e92f65) oxidecomputer/console#2250 * [d7712f1c](oxidecomputer/console@d7712f1c) oxidecomputer/console#2313 * [81bd2abd](oxidecomputer/console@81bd2abd) oxidecomputer/console#2302 * [de7e443f](oxidecomputer/console@de7e443f) link to images doc from the image upload form * [c2e7ca1c](oxidecomputer/console@c2e7ca1c) oxidecomputer/console#2323 * [4147221c](oxidecomputer/console@4147221c) oxidecomputer/console#2319 * [636fed3e](oxidecomputer/console@636fed3e) oxidecomputer/console#2318 * [acce4fdd](oxidecomputer/console@acce4fdd) update silos guide title
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Jul 17, 2024
oxidecomputer/console@4377d01...17ae890 * [17ae890c](oxidecomputer/console@17ae890c) oxidecomputer/console#2331 * [3a25f287](oxidecomputer/console@3a25f287) oxidecomputer/console#2330 * [d7e92f65](oxidecomputer/console@d7e92f65) oxidecomputer/console#2250 * [d7712f1c](oxidecomputer/console@d7712f1c) oxidecomputer/console#2313 * [81bd2abd](oxidecomputer/console@81bd2abd) oxidecomputer/console#2302 * [de7e443f](oxidecomputer/console@de7e443f) link to images doc from the image upload form * [c2e7ca1c](oxidecomputer/console@c2e7ca1c) oxidecomputer/console#2323 * [4147221c](oxidecomputer/console@4147221c) oxidecomputer/console#2319 * [636fed3e](oxidecomputer/console@636fed3e) oxidecomputer/console#2318 * [acce4fdd](oxidecomputer/console@acce4fdd) update silos guide title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a "copy to clipboard" component to the IP cell on the external IPs and network interfaces tables on the instance's networking tab.
As this ends up being practically identical to the IP rendered in the header, I extracted the copy-able IP address into a new
CopyableIpcomponent. (Open to alternate names!) Because we might have occasions where the IP does not need to be linked (like on the Network Interfaces row), the linking is optional.Fixes #2307