React 19 #2699
Merged
React 19 #2699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
force-pushed
the
react-19-again-again
branch
from
949b9e8 to
b35169d
Compare
david-crespo
commented
Feb 17, 2025
| + element.style.pointerEvents = 'none'; | ||
| return element; | ||
| } | ||
| const $3db38b7d1fb3fe6a$export$be92b6f5f03c0fe9 = $3db38b7d1fb3fe6a$export$ac5b58043b79449b; |
Collaborator
Author
There was a problem hiding this comment.
This patch isn't needed anymore because we now depend on a version of this library that incorporated our patch.
$ npm ls @radix-ui/react-focus-guards
oxide@0.0.0 /Users/david/oxide/console
└─┬ @radix-ui/react-dialog@1.1.6
└── @radix-ui/react-focus-guards@1.1.1
david-crespo
commented
Feb 17, 2025
| -RemoveScroll.classNames = { | ||
| - fullWidth: fullWidthClassName, | ||
| - zeroRight: zeroRightClassName, | ||
| -}; |
Collaborator
Author
There was a problem hiding this comment.
This existing bit of the patch wasn't necessary. These lines do not set classes, they set a value RemoveScroll.classNames that is imported by other things and used for stuff.
Collaborator
Author
|
The |
I went through the v5 migration guide and confirmed there was nothing we actually needed to change. https://github.com/pmndrs/zustand/blob/c9330941c8bad6add1c95bb69099c39606151abd/docs/migrations/migrating-to-v5.md
david-crespo
commented
Feb 18, 2025
| <form className="flex"> | ||
| <Listbox | ||
| className="z-10 w-[10rem] border-r border-r-default [&>button]:!rounded-r-none [&>button]:!border-r-0" | ||
| className="z-10 w-[10rem] border-r border-r-default [&_button]:!rounded-r-none [&_button]:!border-r-0" |
Collaborator
Author
There was a problem hiding this comment.
This was needed to fix the border between the Listbox and the button after adding a wrapping div to work around the Headless bug. We can always change it back if want after they fix it.
david-crespo
commented
Feb 18, 2025
| // work at the same time (so that, for example, in theory, a button could be | ||
| // simultaneously disabled with a tooltip *and* be focused programmatically [I | ||
| // tested this]), we merge the two refs inside Tooltip, using child.props.ref to | ||
| // get the original ref on the button. |
Collaborator
Author
There was a problem hiding this comment.
important comment added
charliepark
approved these changes
Feb 18, 2025
Contributor
charliepark
left a comment
charliepark
left a comment
There was a problem hiding this comment.
All of this is looking good to me locally
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Feb 27, 2025
oxidecomputer/console@7de4b11...dc4e0d4 * [dc4e0d4f](oxidecomputer/console@dc4e0d4f) oxidecomputer/console#2712 * [381f374f](oxidecomputer/console@381f374f) oxidecomputer/console#2711 * [32636781](oxidecomputer/console@32636781) oxidecomputer/console#2654 * [a72b460c](oxidecomputer/console@a72b460c) delete unused metrics utils * [3dd06294](oxidecomputer/console@3dd06294) add npm run start:colo * [f591c282](oxidecomputer/console@f591c282) oxidecomputer/console#2707 * [3b838e0b](oxidecomputer/console@3b838e0b) oxidecomputer/console#2706 * [74005f8d](oxidecomputer/console@74005f8d) oxidecomputer/console#2702 * [e8371db1](oxidecomputer/console@e8371db1) make debug ci e2e trace script more flexible * [27e0c130](oxidecomputer/console@27e0c130) oxidecomputer/console#2705 * [db94deab](oxidecomputer/console@db94deab) oxidecomputer/console#2703 * [6ed7d862](oxidecomputer/console@6ed7d862) oxidecomputer/console#2701 * [ba3ab97d](oxidecomputer/console@ba3ab97d) oxidecomputer/console#2699 * [c14b4afa](oxidecomputer/console@c14b4afa) oxidecomputer/console#2693
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Feb 28, 2025
oxidecomputer/console@7de4b11...dc4e0d4 * [dc4e0d4f](oxidecomputer/console@dc4e0d4f) oxidecomputer/console#2712 * [381f374f](oxidecomputer/console@381f374f) oxidecomputer/console#2711 * [32636781](oxidecomputer/console@32636781) oxidecomputer/console#2654 * [a72b460c](oxidecomputer/console@a72b460c) delete unused metrics utils * [3dd06294](oxidecomputer/console@3dd06294) add npm run start:colo * [f591c282](oxidecomputer/console@f591c282) oxidecomputer/console#2707 * [3b838e0b](oxidecomputer/console@3b838e0b) oxidecomputer/console#2706 * [74005f8d](oxidecomputer/console@74005f8d) oxidecomputer/console#2702 * [e8371db1](oxidecomputer/console@e8371db1) make debug ci e2e trace script more flexible * [27e0c130](oxidecomputer/console@27e0c130) oxidecomputer/console#2705 * [db94deab](oxidecomputer/console@db94deab) oxidecomputer/console#2703 * [6ed7d862](oxidecomputer/console@6ed7d862) oxidecomputer/console#2701 * [ba3ab97d](oxidecomputer/console@ba3ab97d) oxidecomputer/console#2699 * [c14b4afa](oxidecomputer/console@c14b4afa) oxidecomputer/console#2693
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redoing #2636 without needing to use
overridesinpackage.jsonby updating some deps and fixing the react peer deps in@oxide/design-system(oxidecomputer/design-system#118) and@oxide/react-asciidoc(oxidecomputer/react-asciidoc#32).Most of our type errors are due to
ReactElement's props generic changing fromanytounknown. See https://react.dev/blog/2024/04/25/react-19-upgrade-guide#changes-to-the-reactelement-typescript-type. This is clearly more correct, and forces us to fix some things we were doing unsafely, but it is annoying.npm installto not blow up@radix-ui/react-focus-guardspatch because we now depend on a version of this library that incorporated our patchreact-remove-scrollpatch — we accidentally have two versions installed and we are patching the wrong one! (see use a content-security-policy in development #2142)data-headlessui-statesupplied toReact.Fragment" warnings on many pages (presumably due to passing a fragment to a headless UI thing that should be a div or something)Effect on bundle size
A little bigger. I think a small increase is expected, but I'm not sure exactly how much. I plan to mitigate this anyway very soon by switching to RRv7 framework mode, which automatically code-splits every route.
Before
After