Mock serial console websocket with MSW #2703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
commented
Feb 19, 2025
| : 'ws://127.0.0.1:' + (apiMode === 'msw' ? 6036 : 12220), | ||
| changeOrigin: true, | ||
| ws: true, | ||
| }, |
Collaborator
Author
There was a problem hiding this comment.
This didn't work unless you manually ran tools/deno/mock-serial-console.ts. Now it all just works.
Collaborator
Author
|
lmao (from the chrome e2e failure trace) 
|
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Feb 27, 2025
oxidecomputer/console@7de4b11...dc4e0d4 * [dc4e0d4f](oxidecomputer/console@dc4e0d4f) oxidecomputer/console#2712 * [381f374f](oxidecomputer/console@381f374f) oxidecomputer/console#2711 * [32636781](oxidecomputer/console@32636781) oxidecomputer/console#2654 * [a72b460c](oxidecomputer/console@a72b460c) delete unused metrics utils * [3dd06294](oxidecomputer/console@3dd06294) add npm run start:colo * [f591c282](oxidecomputer/console@f591c282) oxidecomputer/console#2707 * [3b838e0b](oxidecomputer/console@3b838e0b) oxidecomputer/console#2706 * [74005f8d](oxidecomputer/console@74005f8d) oxidecomputer/console#2702 * [e8371db1](oxidecomputer/console@e8371db1) make debug ci e2e trace script more flexible * [27e0c130](oxidecomputer/console@27e0c130) oxidecomputer/console#2705 * [db94deab](oxidecomputer/console@db94deab) oxidecomputer/console#2703 * [6ed7d862](oxidecomputer/console@6ed7d862) oxidecomputer/console#2701 * [ba3ab97d](oxidecomputer/console@ba3ab97d) oxidecomputer/console#2699 * [c14b4afa](oxidecomputer/console@c14b4afa) oxidecomputer/console#2693
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Feb 28, 2025
oxidecomputer/console@7de4b11...dc4e0d4 * [dc4e0d4f](oxidecomputer/console@dc4e0d4f) oxidecomputer/console#2712 * [381f374f](oxidecomputer/console@381f374f) oxidecomputer/console#2711 * [32636781](oxidecomputer/console@32636781) oxidecomputer/console#2654 * [a72b460c](oxidecomputer/console@a72b460c) delete unused metrics utils * [3dd06294](oxidecomputer/console@3dd06294) add npm run start:colo * [f591c282](oxidecomputer/console@f591c282) oxidecomputer/console#2707 * [3b838e0b](oxidecomputer/console@3b838e0b) oxidecomputer/console#2706 * [74005f8d](oxidecomputer/console@74005f8d) oxidecomputer/console#2702 * [e8371db1](oxidecomputer/console@e8371db1) make debug ci e2e trace script more flexible * [27e0c130](oxidecomputer/console@27e0c130) oxidecomputer/console#2705 * [db94deab](oxidecomputer/console@db94deab) oxidecomputer/console#2703 * [6ed7d862](oxidecomputer/console@6ed7d862) oxidecomputer/console#2701 * [ba3ab97d](oxidecomputer/console@ba3ab97d) oxidecomputer/console#2699 * [c14b4afa](oxidecomputer/console@c14b4afa) oxidecomputer/console#2693
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2072. Realized it was a lot easier than I thought while working on #2702.
2025-02-19-mock-serial.mp4