-
Notifications
You must be signed in to change notification settings - Fork 19
chore: Start converting to RRv7 framework mode #2702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
af3e853 to
84cb056
Compare
| import { pb } from '~/util/path-builder' | ||
|
|
||
| const Terminal = lazy(() => import('~/components/Terminal')) | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
This can be merged as-is, we can convert the rest of the routes gradually. |
| {overrideContentPane || <ContentPane />} | ||
| </PageContainer> | ||
| ) | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just ProjectLayout moved in its entirety. The diff doesn’t show as a rename because the original file is still there, it’s just very short now.
oxidecomputer/console@7de4b11...dc4e0d4 * [dc4e0d4f](oxidecomputer/console@dc4e0d4f) oxidecomputer/console#2712 * [381f374f](oxidecomputer/console@381f374f) oxidecomputer/console#2711 * [32636781](oxidecomputer/console@32636781) oxidecomputer/console#2654 * [a72b460c](oxidecomputer/console@a72b460c) delete unused metrics utils * [3dd06294](oxidecomputer/console@3dd06294) add npm run start:colo * [f591c282](oxidecomputer/console@f591c282) oxidecomputer/console#2707 * [3b838e0b](oxidecomputer/console@3b838e0b) oxidecomputer/console#2706 * [74005f8d](oxidecomputer/console@74005f8d) oxidecomputer/console#2702 * [e8371db1](oxidecomputer/console@e8371db1) make debug ci e2e trace script more flexible * [27e0c130](oxidecomputer/console@27e0c130) oxidecomputer/console#2705 * [db94deab](oxidecomputer/console@db94deab) oxidecomputer/console#2703 * [6ed7d862](oxidecomputer/console@6ed7d862) oxidecomputer/console#2701 * [ba3ab97d](oxidecomputer/console@ba3ab97d) oxidecomputer/console#2699 * [c14b4afa](oxidecomputer/console@c14b4afa) oxidecomputer/console#2693
oxidecomputer/console@7de4b11...dc4e0d4 * [dc4e0d4f](oxidecomputer/console@dc4e0d4f) oxidecomputer/console#2712 * [381f374f](oxidecomputer/console@381f374f) oxidecomputer/console#2711 * [32636781](oxidecomputer/console@32636781) oxidecomputer/console#2654 * [a72b460c](oxidecomputer/console@a72b460c) delete unused metrics utils * [3dd06294](oxidecomputer/console@3dd06294) add npm run start:colo * [f591c282](oxidecomputer/console@f591c282) oxidecomputer/console#2707 * [3b838e0b](oxidecomputer/console@3b838e0b) oxidecomputer/console#2706 * [74005f8d](oxidecomputer/console@74005f8d) oxidecomputer/console#2702 * [e8371db1](oxidecomputer/console@e8371db1) make debug ci e2e trace script more flexible * [27e0c130](oxidecomputer/console@27e0c130) oxidecomputer/console#2705 * [db94deab](oxidecomputer/console@db94deab) oxidecomputer/console#2703 * [6ed7d862](oxidecomputer/console@6ed7d862) oxidecomputer/console#2701 * [ba3ab97d](oxidecomputer/console@ba3ab97d) oxidecomputer/console#2699 * [c14b4afa](oxidecomputer/console@c14b4afa) oxidecomputer/console#2693

This is the beginning of both #2019 and #2695.
Following this helpful guide https://reactrouter.com/upgrading/router-provider, we
convertfunction to convert from framework mode route modules with a default export and aclientLoaderto what library mode wants, namely a namedComponentexport and aloader.<Route>to uselazy={() => import('./path/to/route')}For this PR we can leave it at that, but eventually we will
routes.tsxto a framework moderoute.tsand flip on framework mode by using the RR Vite plugin.In this PR we also make a couple of other tweaks:
app/pagesandapp/layoutsoutput.experimentalMinChunkSizein the Rollup config so we don't get a ton of 300 byte JS chunks.With
output.experimentalMinChunkSizeWithout
output.experimentalMinChunkSize