Fix for issues #138 and #141 #147
Conversation
| auto fields = new IR::IndexedVector<IR::StructField>(); | ||
| for (auto f : *st->fields) { | ||
| auto ftype = typeMap->getType(f); | ||
| auto cftype = convertType(ftype); |
There was a problem hiding this comment.
Does this really need to look up the type in the typemap rather than just using f->type?
There was a problem hiding this comment.
I think so, because the field type may be just a Type_Name; the typeMap holds the canonical type.
Please note that a new Type_Type has been introduced in a previous commit: it represents the type of a type... So to retrieve the field type you can do either:
typeMap->getType(field);
or
typeMap->getTypeType(field->type);
There was a problem hiding this comment.
This should only run after type inferencing has successfully run, so any parameterized type should have been replaced by a specialized type with all the Type_Names replaced with concrete types. So there should never be a Type_Name here.
Moved a pass from mid-end to front-end.
Some bug-fixes in def-use computation.
The originalName of an ID can be nullptr; this is not the same as the name.