Added Redis pingInterval to fix Socket Closed exceptions #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

michaeldisaro merged 3 commits into main from fix-redis-socket-closed

Sep 4, 2024

Contributor

michaeldisaro commented Sep 4, 2024

List of Changes

Added pingInterval to redis client.

Motivation and Context

This should fix the socket closed unexpectedly as reported here redis/node-redis#1598.

How Has This Been Tested?

unit tests
integration tests
build

Types of changes

Chore (nothing changes by a user perspective)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)


          Added Redis pingInterval to fix Socket Closed exceptions

1d2a50f

michaeldisaro requested a review from a team as a code owner

September 4, 2024 13:11

Garma00 approved these changes

View reviewed changes

lucacavallaro self-requested a review

September 4, 2024 13:13

lucacavallaro reviewed

View reviewed changes

Member

lucacavallaro left a comment

LGTM but make sure that this redis module is configured by all the best practices that we use in other projects


          after code review

242d8a8

github-actions bot added the external-interface-changes label


          changed command docker-compose to docker compose

9130fbc

michaeldisaro merged commit 2b55a73 into main

5 checks passed

michaeldisaro deleted the fix-redis-socket-closed branch

September 4, 2024 13:46

github-merge-queue bot pushed a commit that referenced this pull request


          Version Packages (#198)

707497e

This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## push-notifications-func@1.0.0

### Major Changes

-   069ee9e: First release

All notable changes to this project will be documented in this file.
Dates are displayed in UTC.

Generated by
[`auto-changelog`](https://github.com/CookPete/auto-changelog).

####
[v4.1.0](pagopa/io-functions-pushnotifications@v4.0.0...v4.1.0)

- Merge pull request #75 from pagopa/replace-azure-sb
[`1ea7798`](pagopa/io-functions-pushnotifications@1ea7798)
- WIP: fix unit test
[`753de47`](pagopa/io-functions-pushnotifications@753de47)
- WIP: replace sb with notification hub library and make tsc compile
[`1b59d1d`](pagopa/io-functions-pushnotifications@1b59d1d)

####
[v4.0.0](pagopa/io-functions-pushnotifications@v4.0.0-RELEASE...v4.0.0)

> 4 April 2023

####
[v4.0.0-RELEASE](pagopa/io-functions-pushnotifications@v3.0.2...v4.0.0-RELEASE)

> 4 April 2023

- [#ICC-343] node 18 upgrade
[`#70`](pagopa/io-functions-pushnotifications#70)
- Update ts-commons and fn-commons in order to be based on Node 18
[`1a9ee85`](pagopa/io-functions-pushnotifications@1a9ee85)
- Bump version to 4.0.0 [skip
ci][`6ec21be`](<pagopa/io-functions-pushnotifications@6ec21be>)
- Fix build and unit test
[`ff4326f`](pagopa/io-functions-pushnotifications@ff4326f)

####
[v3.0.2](pagopa/io-functions-pushnotifications@v3.0.2-RELEASE...v3.0.2)

> 4 April 2023

####
[v3.0.2-RELEASE](pagopa/io-functions-pushnotifications@v3.0.1...v3.0.2-RELEASE)

> 4 April 2023

- Bump version to 3.0.2 [skip
ci][`6e548a4`](<pagopa/io-functions-pushnotifications@6e548a4>)

####
[v3.0.1](pagopa/io-functions-pushnotifications@v3.0.1-RELEASE...v3.0.1)

> 4 April 2023

####
[v3.0.1-RELEASE](pagopa/io-functions-pushnotifications@v3.0.0...v3.0.1-RELEASE)

> 4 April 2023

- Fix storage version
[`#71`](pagopa/io-functions-pushnotifications#71)
- Bump version to 3.0.1 [skip
ci][`4238e1d`](<pagopa/io-functions-pushnotifications@4238e1d>)

####
[v3.0.0](pagopa/io-functions-pushnotifications@v3.0.0-RELEASE...v3.0.0)

> 4 April 2023

####
[v3.0.0-RELEASE](pagopa/io-functions-pushnotifications@v2.0.0...v3.0.0-RELEASE)

> 4 April 2023

- Bump version to 3.0.0 [skip
ci][`633d910`](<pagopa/io-functions-pushnotifications@633d910>)

####
[v2.0.0](pagopa/io-functions-pushnotifications@v2.0.0-RELEASE...v2.0.0)

> 3 April 2023

####
[v2.0.0-RELEASE](pagopa/io-functions-pushnotifications@v1.17.0...v2.0.0-RELEASE)

> 3 April 2023

- [#ICC-345] Remove danger
[`#69`](pagopa/io-functions-pushnotifications#69)
- Fix yarn lock
[`abb4437`](pagopa/io-functions-pushnotifications@abb4437)
- Remove Dangerfile.ts
[`d304988`](pagopa/io-functions-pushnotifications@d304988)
- Remove danger from pipeline
[`56f70ca`](pagopa/io-functions-pushnotifications@56f70ca)

####
[v1.17.0](pagopa/io-functions-pushnotifications@v1.17.0-RELEASE...v1.17.0)

> 10 August 2022

####
[v1.17.0-RELEASE](pagopa/io-functions-pushnotifications@v1.16.0...v1.17.0-RELEASE)

> 10 August 2022

- Bump version to 1.17.0 [skip
ci][`c985b59`](<pagopa/io-functions-pushnotifications@c985b59>)

####
[v1.16.0](pagopa/io-functions-pushnotifications@v1.16.0-RELEASE...v1.16.0)

> 10 August 2022

####
[v1.16.0-RELEASE](pagopa/io-functions-pushnotifications@v1.15.0...v1.16.0-RELEASE)

> 10 August 2022

- Bump version to 1.16.0 [skip
ci][`ae00b4d`](<pagopa/io-functions-pushnotifications@ae00b4d>)

####
[v1.15.0](pagopa/io-functions-pushnotifications@v1.15.0-RELEASE...v1.15.0)

> 10 August 2022

####
[v1.15.0-RELEASE](pagopa/io-functions-pushnotifications@v1.14.6...v1.15.0-RELEASE)

> 10 August 2022

- [#ICC-159] Migrate pushNotification.notifyMessage from durable
function to queue
[`#57`](pagopa/io-functions-pushnotifications#57)
- Bump version to 1.15.0 [skip
ci][`09bd8f1`](<pagopa/io-functions-pushnotifications@09bd8f1>)
- Merge pull request #52 from pagopa/ip-456--azure-templates-v18
[`b0d811c`](pagopa/io-functions-pushnotifications@b0d811c)
- [#ip-456] Update codegen to fix client SDK generation
[`9395841`](pagopa/io-functions-pushnotifications@9395841)

####
[v1.14.6](pagopa/io-functions-pushnotifications@v1.14.6-RELEASE...v1.14.6)

> 21 September 2021

####
[v1.14.6-RELEASE](pagopa/io-functions-pushnotifications@v1.14.5...v1.14.6-RELEASE)

> 21 September 2021

- Move to common healthcheck implementation
[`#48`](pagopa/io-functions-pushnotifications#48)
- Bump version to 1.14.6 [skip
ci][`b07e1bf`](<pagopa/io-functions-pushnotifications@b07e1bf>)
- Merge pull request #36 from pagopa/IP-342--upgrade-fp-ts
[`1d4e631`](pagopa/io-functions-pushnotifications@1d4e631)
- [#IP-342] moved to common healthcheck implementations
[`deacae1`](pagopa/io-functions-pushnotifications@deacae1)

####
[v1.14.5](pagopa/io-functions-pushnotifications@v1.14.5-RELEASE...v1.14.5)

> 20 August 2021

####
[v1.14.5-RELEASE](pagopa/io-functions-pushnotifications@v1.14.4...v1.14.5-RELEASE)

> 20 August 2021

- Bump version to 1.14.5 [skip
ci][`7f6c4af`](<pagopa/io-functions-pushnotifications@7f6c4af>)

####
[v1.14.4](pagopa/io-functions-pushnotifications@v1.14.4-RELEASE...v1.14.4)

> 20 August 2021

####
[v1.14.4-RELEASE](pagopa/io-functions-pushnotifications@v1.14.3...v1.14.4-RELEASE)

> 20 August 2021

- change durable function storage
[`#47`](pagopa/io-functions-pushnotifications#47)
- Bump version to 1.14.4 [skip
ci][`ffc3e63`](<pagopa/io-functions-pushnotifications@ffc3e63>)

####
[v1.14.3](pagopa/io-functions-pushnotifications@v1.14.3-RELEASE...v1.14.3)

> 18 August 2021

####
[v1.14.3-RELEASE](pagopa/io-functions-pushnotifications@v1.14.2...v1.14.3-RELEASE)

> 18 August 2021

- Bump version to 1.14.3 [skip
ci][`8590799`](<pagopa/io-functions-pushnotifications@8590799>)
- Merge pull request #42 from pagopa/IP-360--update-node-version
[`ecb4937`](pagopa/io-functions-pushnotifications@ecb4937)
- Merge pull request #46 from pagopa/revert-16-mitigate-ms-issue
[`803f8a2`](pagopa/io-functions-pushnotifications@803f8a2)

####
[v1.14.2](pagopa/io-functions-pushnotifications@v1.14.2-RELEASE...v1.14.2)

> 14 June 2021

####
[v1.14.2-RELEASE](pagopa/io-functions-pushnotifications@v1.14.1...v1.14.2-RELEASE)

> 14 June 2021

- Bump version to 1.14.2 [skip
ci][`a9fb6c5`](<pagopa/io-functions-pushnotifications@a9fb6c5>)
- Merge pull request #32 from pagopa/IP-116--createOrUpdate-ff-disposal
[`3cab90a`](pagopa/io-functions-pushnotifications@3cab90a)
- [#IP-116] remove feature flag from CreateOrUpdate
[`a8c2575`](pagopa/io-functions-pushnotifications@a8c2575)

####
[v1.14.1](pagopa/io-functions-pushnotifications@v1.14.1-RELEASE...v1.14.1)

> 9 June 2021

####
[v1.14.1-RELEASE](pagopa/io-functions-pushnotifications@v1.14.0...v1.14.1-RELEASE)

> 9 June 2021

- Disable Local RPC durable task
[`#34`](pagopa/io-functions-pushnotifications#34)
- Bump version to 1.14.1 [skip
ci][`65bac54`](<pagopa/io-functions-pushnotifications@65bac54>)

####
[v1.14.0](pagopa/io-functions-pushnotifications@v1.14.0-RELEASE...v1.14.0)

> 9 June 2021

####
[v1.14.0-RELEASE](pagopa/io-functions-pushnotifications@v1.13.0...v1.14.0-RELEASE)

> 9 June 2021

- Add user blacklist
[`#33`](pagopa/io-functions-pushnotifications#33)
- Bump version to 1.14.0 [skip
ci][`e42cfb5`](<pagopa/io-functions-pushnotifications@e42cfb5>)

####
[v1.13.0](pagopa/io-functions-pushnotifications@v1.13.0-RELEASE...v1.13.0)

> 11 May 2021

####
[v1.13.0-RELEASE](pagopa/io-functions-pushnotifications@v1.12.0...v1.13.0-RELEASE)

> 11 May 2021

- [#IP-146] NH partitions - RFC 72 (step 3)
[`#28`](pagopa/io-functions-pushnotifications#28)
- [IP-146] NH partitions - RFC 72 (step 3)
[`db6eb8f`](pagopa/io-functions-pushnotifications@db6eb8f)
- [#IP-146][IP-146] moved delete outside try-catch
[`400887e`](pagopa/io-functions-pushnotifications@400887e)
- Bump version to 1.13.0 [skip
ci][`1870757`](<pagopa/io-functions-pushnotifications@1870757>)

####
[v1.12.0](pagopa/io-functions-pushnotifications@v1.12.0-RELEASE...v1.12.0)

> 5 May 2021

####
[v1.12.0-RELEASE](pagopa/io-functions-pushnotifications@v1.11.0...v1.12.0-RELEASE)

> 5 May 2021

- [#IP-146] Remove feature flag from Notify and Delete
[`#30`](pagopa/io-functions-pushnotifications#30)
- [#IP-146] add tests to healthcheck
[`f5df51f`](pagopa/io-functions-pushnotifications@f5df51f)
- [#IP-146] small test refactoring
[`4dda692`](pagopa/io-functions-pushnotifications@4dda692)
- [#IP-146][IP-146] remove FF from delete
[`d13dba1`](pagopa/io-functions-pushnotifications@d13dba1)

####
[v1.11.0](pagopa/io-functions-pushnotifications@v1.11.0-RELEASE...v1.11.0)

> 30 April 2021

####
[v1.11.0-RELEASE](pagopa/io-functions-pushnotifications@v1.10.0...v1.11.0-RELEASE)

> 30 April 2021

- [#IP-146] Add installationId and NH partition to telemetry event
[`#29`](pagopa/io-functions-pushnotifications#29)
- Bump version to 1.11.0 [skip
ci][`7337ae7`](<pagopa/io-functions-pushnotifications@7337ae7>)
- [#IP-146] add installationId and NH partition to telemetry event
[`8bfd7f8`](pagopa/io-functions-pushnotifications@8bfd7f8)

####
[v1.10.0](pagopa/io-functions-pushnotifications@v1.10.0-RELEASE...v1.10.0)

> 29 April 2021

####
[v1.10.0-RELEASE](pagopa/io-functions-pushnotifications@v1.9.0...v1.10.0-RELEASE)

> 29 April 2021

- [IP-146] NH partition management - RFC72 Step 2
[`#24`](pagopa/io-functions-pushnotifications#24)
- second way to handle partitions from env file
[`6922170`](pagopa/io-functions-pushnotifications@6922170)
- [#IP-146][#IP-146] compute AZURE_NOTIFICATION_HUB_PARTITIONS
[`a6c10e4`](pagopa/io-functions-pushnotifications@a6c10e4)
- [#IP-146] refactor codecs
[`4dedd8b`](pagopa/io-functions-pushnotifications@4dedd8b)

####
[v1.9.0](pagopa/io-functions-pushnotifications@v1.9.0-RELEASE...v1.9.0)

> 26 April 2021

####
[v1.9.0-RELEASE](pagopa/io-functions-pushnotifications@v1.8.0...v1.9.0-RELEASE)

> 26 April 2021

- Notification error handling
[`#25`](pagopa/io-functions-pushnotifications#25)
- wip
[`dfee944`](pagopa/io-functions-pushnotifications@dfee944)
- changes to NH error handling
[`c4b25c7`](pagopa/io-functions-pushnotifications@c4b25c7)
- Bump version to 1.9.0 [skip
ci][`a1506a9`](<pagopa/io-functions-pushnotifications@a1506a9>)

####
[v1.8.0](pagopa/io-functions-pushnotifications@v1.8.0-RELEASE...v1.8.0)

> 21 April 2021

####
[v1.8.0-RELEASE](pagopa/io-functions-pushnotifications@v1.7.0...v1.8.0-RELEASE)

> 21 April 2021

- Bump version to 1.8.0 [skip
ci][`b620f62`](<pagopa/io-functions-pushnotifications@b620f62>)
- Merge pull request #22 from
pagopa/IP-94-static-partitioning-for-canary-users
[`67793d7`](pagopa/io-functions-pushnotifications@67793d7)
- [IP-94] Check canary users with regex
[`444e97e`](pagopa/io-functions-pushnotifications@444e97e)

####
[v1.7.0](pagopa/io-functions-pushnotifications@v1.7.0-RELEASE...v1.7.0)

> 19 April 2021

####
[v1.7.0-RELEASE](pagopa/io-functions-pushnotifications@v1.6.0...v1.7.0-RELEASE)

> 19 April 2021

- [IP-89] Add feature flags management
[`#17`](pagopa/io-functions-pushnotifications#17)
- [#IP-84] Change strict configuration to true
[`#20`](pagopa/io-functions-pushnotifications#20)
- [IP-89] rebase + use new activity in orchestrators
[`27c5374`](pagopa/io-functions-pushnotifications@27c5374)
- removed unused functions
[`800d9ff`](pagopa/io-functions-pushnotifications@800d9ff)
- [IP-91] make UserInActiveSubsetActivity to call a retry
[`9821fc8`](pagopa/io-functions-pushnotifications@9821fc8)

####
[v1.6.0](pagopa/io-functions-pushnotifications@v1.6.0-RELEASE...v1.6.0)

> 13 April 2021

####
[v1.6.0-RELEASE](pagopa/io-functions-pushnotifications@v1.5.0...v1.6.0-RELEASE)

> 13 April 2021

- Bump version to 1.6.0 [skip
ci][`a319dd8`](<pagopa/io-functions-pushnotifications@a319dd8>)
- Merge pull request #8 from pagopa/IP-43-notifyMessage-orchestrator
[`ae45627`](pagopa/io-functions-pushnotifications@ae45627)
- rebase with IP-42
[`5a58784`](pagopa/io-functions-pushnotifications@5a58784)

####
[v1.5.0](pagopa/io-functions-pushnotifications@v1.5.0-RELEASE...v1.5.0)

> 12 April 2021

####
[v1.5.0-RELEASE](pagopa/io-functions-pushnotifications@v1.4.0...v1.5.0-RELEASE)

> 12 April 2021

- [#IP-42] Activity error handling
[`#21`](pagopa/io-functions-pushnotifications#21)
- Bump version to 1.5.0 [skip
ci][`1cc8aca`](<pagopa/io-functions-pushnotifications@1cc8aca>)
- Merge pull request #7 from
pagopa/IP-42-deleteInstallation-orchestrator
[`24ad6ef`](pagopa/io-functions-pushnotifications@24ad6ef)
- refactor with orchestrator and activity utilities
[`4809362`](pagopa/io-functions-pushnotifications@4809362)

####
[v1.4.0](pagopa/io-functions-pushnotifications@v1.4.0-RELEASE...v1.4.0)

> 8 April 2021

####
[v1.4.0-RELEASE](pagopa/io-functions-pushnotifications@v1.3.0...v1.4.0-RELEASE)

> 8 April 2021

- Bump version to 1.4.0 [skip
ci][`0f5ae56`](<pagopa/io-functions-pushnotifications@0f5ae56>)
- Merge pull request #6 from pagopa/IP-41-createOrUpdate-orchestrator
[`18020c1`](pagopa/io-functions-pushnotifications@18020c1)
- implement new durable utilities
[`5e1d3c1`](pagopa/io-functions-pushnotifications@5e1d3c1)

####
[v1.3.0](pagopa/io-functions-pushnotifications@v1.3.0-RELEASE...v1.3.0)

> 2 April 2021

####
[v1.3.0-RELEASE](pagopa/io-functions-pushnotifications@v1.2.0...v1.3.0-RELEASE)

> 2 April 2021

- Deploy directly on production slot
[`#16`](pagopa/io-functions-pushnotifications#16)
- Bump version to 1.3.0 [skip
ci][`c4a62d9`](<pagopa/io-functions-pushnotifications@c4a62d9>)
- Merge pull request #19 from pagopa/IP-122-reduce-log-data-ingestion
[`1d53a3e`](pagopa/io-functions-pushnotifications@1d53a3e)
- refactor test environment
[`a6167c6`](pagopa/io-functions-pushnotifications@a6167c6)

####
[v1.2.0](pagopa/io-functions-pushnotifications@v1.2.0-RELEASE...v1.2.0)

> 29 March 2021

####
[v1.2.0-RELEASE](pagopa/io-functions-pushnotifications@v1.1.2...v1.2.0-RELEASE)

> 29 March 2021

- [IP-43] changed connection name
[`#15`](pagopa/io-functions-pushnotifications#15)
- Bump version to 1.2.0 [skip
ci][`66e5b49`](<pagopa/io-functions-pushnotifications@66e5b49>)

####
[v1.1.2](pagopa/io-functions-pushnotifications@v1.1.2-RELEASE...v1.1.2)

> 29 March 2021

####
[v1.1.2-RELEASE](pagopa/io-functions-pushnotifications@v1.1.1...v1.1.2-RELEASE)

> 29 March 2021

- Bump version to 1.1.2 [skip
ci][`0063109`](<pagopa/io-functions-pushnotifications@0063109>)
- Merge pull request #13 from pagopa/remove-cosmos-env-variables
[`91e1510`](pagopa/io-functions-pushnotifications@91e1510)
- removed unused cosmosdb.ts and variables
[`d698c80`](pagopa/io-functions-pushnotifications@d698c80)

####
[v1.1.1](pagopa/io-functions-pushnotifications@v1.1.1-RELEASE...v1.1.1)

> 25 March 2021

####
[v1.1.1-RELEASE](pagopa/io-functions-pushnotifications@v1.1.0...v1.1.1-RELEASE)

> 25 March 2021

- [#IP-101] Refactor pipelines
[`#11`](pagopa/io-functions-pushnotifications#11)
- Fix durable functions config
[`#9`](pagopa/io-functions-pushnotifications#9)
- Bump version to 1.1.1 [skip
ci][`a36a9de`](<pagopa/io-functions-pushnotifications@a36a9de>)
- Merge pull request #10 from pagopa/remove-extensionBundle
[`30ebb95`](pagopa/io-functions-pushnotifications@30ebb95)
- test danger error
[`43f65f3`](pagopa/io-functions-pushnotifications@43f65f3)

####
[v1.1.0](pagopa/io-functions-pushnotifications@v1.1.0-RELEASE...v1.1.0)

> 24 March 2021

#### v1.1.0-RELEASE

> 24 March 2021

- [#IP-48] Notification management setup
[`#3`](pagopa/io-functions-pushnotifications#3)
- Initial commit
[`0bf9d19`](pagopa/io-functions-pushnotifications@0bf9d19)
- wip - moved notification queue handlers
[`77ea69e`](pagopa/io-functions-pushnotifications@77ea69e)
- Removed unused functions, cleanup settings
[`954e5a1`](pagopa/io-functions-pushnotifications@954e5a1)


[IP-146]:
https://pagopa.atlassian.net/browse/IP-146?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external-interface-changes