-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Jammy Tiny Implementation #2
Conversation
Signed-off-by: Rob Dimsdale-Zucker <rdimsdale@vmware.com>
Signed-off-by: Rob Dimsdale-Zucker <rdimsdale@vmware.com>
Signed-off-by: Rob Dimsdale-Zucker <rdimsdale@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fg-j & @robdimsdale, the broad strokes on this PR look great! I have some concerns about the size and complexity of the create-release.yml
workflow though. I've made some comments in a couple of areas that I hope could reduce some of that complexity. Let me know what you think.
- once the PR is merged they should point to the new repository.
❗ quick pause! I'd like to propose we switch to using Very easy to implement. See #8 I've moved this PR into draft state while I finish iterating on the new package receipt approach. I'll undraft once it's completed. |
This reverts commit f5af349.
and try using env vars to set global variables Signed-off-by: Rob Dimsdale-Zucker <rdimsdale@vmware.com>
Signed-off-by: Rob Dimsdale-Zucker <rdimsdale@vmware.com>
Signed-off-by: Rob Dimsdale-Zucker <rdimsdale@vmware.com>
because the descriptions sometimes break JSON unmarshalling Signed-off-by: Rob Dimsdale-Zucker <rdimsdale@vmware.com>
Signed-off-by: Rob Dimsdale-Zucker <rdimsdale@vmware.com>
Tested locally on my Mac workstation and found logging/documentation helpful:
|
I just merged in paketo-buildpacks/github-config#477 also, if you wish to update the workflow to use the issue-filing action. Up to you though |
Co-authored-by: Sophie Wigmore <sophiemwigmore@gmail.com>
@sophiewigmore Let's just get this PR in and we can tidy up the failure alert later. |
@ryanmoran anything else you'd like on this? Otherwise I'm merging it in |
@sophiewigmore, nothing that should block this going in. Merge at will. |
Summary
Resolves #1
To Do:
Outstanding issues that can/should be tackled later
get-usns
action Add test coverage to stacks actions github-config#482Checklist