Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Jammy Tiny Implementation #2

Merged
merged 133 commits into from
Jun 21, 2022
Merged

Conversation

fg-j
Copy link

@fg-j fg-j commented May 23, 2022

Summary

Resolves #1

To Do:

  • Create an action that searches previous releases for patched USN JSON files. Pass this JSON as input to the Get USNs action.
  • Create an action that takes two package receipts as input and produces a package diff split into lists of added and removed packages as output. May be very similar to this existing action.
  • Add a check to see if packages have been REMOVED since the previous release. Fail the release workflow if so.
  • Update the create release workflow to only cut a release if
    • the acceptance tests pass AND
    • either of the build/run images are different than the previous release OR
    • the force-creation flag is set
  • Fix the Increment Tag action to allow re-tagging a commit that's already been tagged (Allow re-tagging the same commit github-config#474)
  • Do not report the build as failed if there are no changes - just do not create a release.
  • Actually run the integration tests
  • TODOs in stack/stack.toml
  • TODOs in metadata_test.go
  • TODOs in actions/find-release-asset/entrypoint
  • TODOs in actions/find-and-download-asset/action.yml
  • TODOs in scripts/receipts.sh
  • TODOs in actions/get-usns/entrypoint/main.go
  • TODOs in .github/workflows/create-release.yml
  • Remove extraneous comments / dead code

Outstanding issues that can/should be tackled later

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

Frankie Gallina-Jones added 2 commits May 23, 2022 15:40
Signed-off-by: Rob Dimsdale-Zucker <rdimsdale@vmware.com>
Signed-off-by: Rob Dimsdale-Zucker <rdimsdale@vmware.com>
@fg-j fg-j changed the title Initially Jammy Tiny Implementation Initial Jammy Tiny Implementation May 23, 2022
Copy link
Member

@ryanmoran ryanmoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fg-j & @robdimsdale, the broad strokes on this PR look great! I have some concerns about the size and complexity of the create-release.yml workflow though. I've made some comments in a couple of areas that I hope could reduce some of that complexity. Let me know what you think.

ryanmoran
ryanmoran previously approved these changes Jun 14, 2022
- once the PR is merged they should point to the new repository.
@fg-j
Copy link
Author

fg-j commented Jun 15, 2022

❗ quick pause!

I'd like to propose we switch to using syft to generate package receipts/SBOMs before this merges!

Very easy to implement. See #8

I've moved this PR into draft state while I finish iterating on the new package receipt approach. I'll undraft once it's completed.

@fg-j fg-j marked this pull request as draft June 15, 2022 21:02
Frankie Gallina-Jones added 8 commits June 15, 2022 17:11
and try using env vars to set global variables

Signed-off-by: Rob Dimsdale-Zucker <rdimsdale@vmware.com>
Signed-off-by: Rob Dimsdale-Zucker <rdimsdale@vmware.com>
Signed-off-by: Rob Dimsdale-Zucker <rdimsdale@vmware.com>
because the descriptions sometimes break JSON unmarshalling

Signed-off-by: Rob Dimsdale-Zucker <rdimsdale@vmware.com>
Signed-off-by: Rob Dimsdale-Zucker <rdimsdale@vmware.com>
@fg-j fg-j marked this pull request as ready for review June 16, 2022 18:43
@fg-j fg-j requested review from sophiewigmore and ryanmoran June 16, 2022 18:43
@sophiewigmore
Copy link
Member

Tested locally on my Mac workstation and found logging/documentation helpful:

  • scripts/create.sh
  • scripts/receipts.sh
  • scripts/test.sh
    Also found the create-release workflow steps to be pretty clear. I think I would benefit as a maintainer having the different release criteria outlined somewhere (i.e. when an auto-release can happen vs when pressing the big red button is needed), however I don't think that needs to happen here. I left one nitpick change and then I'm personally good to approve this in and see how it goes maintaining it and using the workflows in reality.

@sophiewigmore
Copy link
Member

I just merged in paketo-buildpacks/github-config#477 also, if you wish to update the workflow to use the issue-filing action. Up to you though

Co-authored-by: Sophie Wigmore <sophiemwigmore@gmail.com>
@fg-j
Copy link
Author

fg-j commented Jun 17, 2022

@sophiewigmore Let's just get this PR in and we can tidy up the failure alert later.

@sophiewigmore
Copy link
Member

@ryanmoran anything else you'd like on this? Otherwise I'm merging it in

@ryanmoran
Copy link
Member

@sophiewigmore, nothing that should block this going in. Merge at will.

@sophiewigmore sophiewigmore merged commit 1c4156b into paketo-buildpacks:main Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Paketo Stacks RFC 0004: Jammy Jellyfish
5 participants