Break on lambda argument in method chain

[gatesn]

Before this PR

Chained calls involving lambda expressions don't line break, which conflicts with checkstyle (at least the gradle-baseline checkstyle config)

class PalantirLambdaInliningPrefersBreak {
    void foo() {
        return hello.read(txn -> {
                    doSomeWork();
                    doSomeMoreWork();
                })
                .chainedCall(() -> {
                    doSomeWork();
                });
    }
}

After this PR

class PalantirLambdaInliningPrefersBreak {
    void foo() {
        return hello
                .read(txn -> {
                    doSomeWork();
                    doSomeMoreWork();
                })
                .chainedCall(() -> {
                    doSomeWork();
                });
    }
}

Possible downsides?

🤷‍♂️ I've also added a test to show that non-chained lambda calls don't include a line break

[changelog-app]

Generate changelog in changelog/@unreleased

Type

• Feature
• Improvement
• Fix
• Break
• Deprecation
• Manual task
• Migration

Description

Break on lambda argument in method chain

Before this PR

Chained calls involving lambda expressions don't line break, which conflicts with checkstyle (at least the gradle-baseline checkstyle config)

class PalantirLambdaInliningPrefersBreak {
    void foo() {
        return hello.read(txn -> {
                    doSomeWork();
                    doSomeMoreWork();
                })
                .chainedCall(() -> {
                    doSomeWork();
                });
    }
}

After this PR

class PalantirLambdaInliningPrefersBreak {
    void foo() {
        return hello
                .read(txn -> {
                    doSomeWork();
                    doSomeMoreWork();
                })
                .chainedCall(() -> {
                    doSomeWork();
                });
    }
}

Possible downsides?

🤷‍♂️ I've also added a test to show that non-chained lambda calls don't include a line break

Check the box to generate changelog(s)

• Generate changelog entry

[svc-autorelease]

Released 2.21.0

[iamdanfox]

@gatesn what was the specific checkstyle thing that was objecting here? I've never encountered this error personally

[robert3005]

you can see a test case - it's a chained lambda invocation (with multi statement lambdas) of variable name that's <8 characters

[iamdanfox]

DW nick slacked me. My question was because this PR said it was fixing a checkstyle rule, but didn't specific which checkstyle rule. The screenshot showed Checkstyle: 'block' child has incorrect indentation level 20, expected level should be 12/