Fix lambda compactness regression

[carterkozak]

This reverts #708 and #707 which made expression lambdas less
readable.

==COMMIT_MSG==
Fix lambda compactness regression
==COMMIT_MSG==

[changelog-app]

Generate changelog in changelog/@unreleased

Type

• Feature
• Improvement
• Fix
• Break
• Deprecation
• Manual task
• Migration

Description

Fix lambda compactness regression

Check the box to generate changelog(s)

• Generate changelog entry

[svc-autorelease]

Released 2.23.0

[robert3005]

This causes conflicts with checkstyle rules in https://github.com/palantir/gradle-baseline/ :/

[carterkozak]

I verified that the test output is compatible with baseline checkstyle configuration

[robert3005]

ok, I have an actual repro. The lambda has to be more > 10 lines. Will make a pr

[robert3005]

after digging more the included test does not pass it. The thing that it boils down to is https://github.com/palantir/gradle-baseline/blob/2a485956a20e7f2ae9a9ddfa689255e347aa96a9/gradle-baseline-java/src/main/groovy/com/palantir/baseline/plugins/BaselineConfig.java#L105-L141 and our detection not being fully robust. So... my proposal here is to kill that logic I linked and make that the default checkstyle?

[gatesn]

@carterkozak do you have an example of a less readable case?

Happy with the revert if we fix the checkstyle plugin config issue, but I also thought it looked a bit prettier!