Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only apply line break to lambdas with statements #708

Merged
merged 3 commits into from
Apr 13, 2022

Conversation

gatesn
Copy link
Contributor

@gatesn gatesn commented Apr 13, 2022

Before this PR

Previous PR #707 was a little aggressive and inserted line breaks for non-statement lambdas.

After this PR

Only multi-line lambdas cause a line-break in the method chain.

@changelog-app
Copy link

changelog-app bot commented Apr 13, 2022

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Only apply line break to lambdas with statements

Before this PR

Previous PR #707 was a little aggressive and inserted line breaks for non-statement lambdas.

After this PR

Only multi-line lambdas cause a line-break in the method chain.

Check the box to generate changelog(s)

  • Generate changelog entry

@robert3005
Copy link
Contributor

This does unify the behaviour for short and long identifiers and no longer produces extraneous breaks in case of expression lambdas

@bulldozer-bot bulldozer-bot bot merged commit f92dcb7 into develop Apr 13, 2022
@bulldozer-bot bulldozer-bot bot deleted the ngates/fix-to-statement-lambda-only branch April 13, 2022 10:57
@svc-autorelease
Copy link
Collaborator

Released 2.22.0

carterkozak added a commit that referenced this pull request Apr 28, 2022
This reverts #708 and #707 which made expression lambdas less
readable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants