forked from kenwheeler/slick
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull Release v1.8.0 #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ `aria-label` not needed where button text content reads as we want screen readers to read + `tabindex` not needed since button element is able to receive focus by default + `role` not needed if intended role matches default of element
+ `aria-required` is not needed here; helpful more on, e.g., input fields that are required
…mentation of tabpanel
…essible tabpanel UI pattern
…rol / tab in initADA
account for instances of slick where slide to dot mapping is not 1-1
…t slide, interactable-with child elements of this slide are made focusable (again)
https://api.jquery.com/ready/ > jQuery offers several ways to attach a function that will run when the DOM is ready. All of the following syntaxes are equivalent: > > $( handler ) > $( document ).ready( handler ) > $( "document" ).ready( handler ) > $( "img" ).ready( handler ) > $().ready( handler ) > As of jQuery 3.0, only the first syntax is recommended; the other syntaxes still work but are deprecated.
#1207 White spaces when using variableWidth and infinite to true
fix vertical + centerMode issues (#2998)
Fix JavaScript Error when enabling arrows by breakpoint
Added option to enable focus on slide change
As per issue #3044
Issue #3009: Show dots only when needed
Changed the logic for adding aria describedby attribute
Show dots only when needed
Not to scroll when infinite scrolling isn't on
Update - added focusOnSelect
Fixes bug in responsive rows
when focusOnChange is false -> remove attr tabindex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog - Release v1.8.0: