Support Suppressions in Analysis Specification File #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacknagz
approved these changes
Nov 8, 2019
| @@ -28,7 +28,7 @@ install: | |||
| pipenv install | |||
|
|
|||
| unit: | |||
| nosetests -v | |||
| pipenv run nosetests -v | |||
There was a problem hiding this comment.
Any reason to add this? pipenv is actually called in the ci task
There was a problem hiding this comment.
Using the unit make target directly fails without this, whereas other make targets such as make fmt, make integration, and make lint do not. I don't feel strongly about this, it just seemed weird that it was the only make target that must be run with pipenv run to not error. Should I revert?
There was a problem hiding this comment.
CI seemed to be unaffected, so it's fine to leave!
lindsey-w
pushed a commit
that referenced
this pull request
Sep 24, 2020
* updated the installation instructions * tweaked wording
kbroughton
referenced
this pull request
in kbroughton/panther-analysis
Jul 22, 2022
Add GCP base helpers
nkulig
pushed a commit
that referenced
this pull request
Jan 9, 2023
natezpanther
added a commit
that referenced
this pull request
Jan 25, 2023
* T1499:TA0040 Endpoint DoS Query + Detection * Fixing the linter * Linter fix #2 * Linter fix #3 * Linter fix #4 * Linter fix #5 * Linter Fix #6 * Added highest_count dictionary to reduce false positives * Fixing get_key() * Disabling detection prior to merge Co-authored-by: Nate Zemanek <natezemanek@US-ML40NMGH9Q.localdomain> Co-authored-by: Nate Zemanek <natezemanek@US-ML40NMGH9Q.local>
melenevskyi
pushed a commit
that referenced
this pull request
Dec 12, 2023
* Sorted testing (#1) Add command-line argument sort-test-results to panther_analysis_tool When set,sort-test-results will bucket test results output by passed/errored status, and will sort test cases by Rule ID * Minor updates - rename variable, conditional print (#2) * Print passed tests first, followed by failed * Sort tests by Rule ID * Add container * Add container * Add container * Add logic to print organized output when a results container is passed. * Add container * Update version * Update version * Update version * Update version * Update version * Update version * Update version * Update version * Update version * Update version * Update version * Update version * Update version * Update version * Update version * Update version * Update version * Update version * Update version * Update version * Update version * Update version * rename variable. Only print detection ID in setup_run_tests when not sorting test results * Conditionally print blank lines (#3) * Conditionally print blank line * Conditionally print blank line * Use implied bool arg (#4) * Conditionally print blank line * Conditionally print blank line * Update arg implementation * Update arg implementation * Apply diff from Panther (#5) * Apply diff from panther * Lint with black (#6) * lint with black --------- Co-authored-by: Chris Dzombak <chris@chrisdzombak.net> Co-authored-by: Evan Gibler <evan.gibler@panther.com>
egibs
pushed a commit
that referenced
this pull request
Dec 15, 2023
* Add Workflow to upload on merge to main * Update job names
egibs
pushed a commit
that referenced
this pull request
Dec 15, 2023
* Add Workflow to upload on merge to main * Update job names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Allow a
Suppressionsfield in the analysis configurations file in order to support managing suppressions in code.Changes
SPEC_SCHEMAschema definitionTesting