-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S3 Lifecycle Policy Fix, Licensing, and More #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhakmiller
approved these changes
Jan 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
pip install --upgrade –r requirements-top-level.txt | ||
pip freeze –r requirements-top-level.txt > requirements.txt | ||
pip3 install -r requirements-top-level.txt --upgrade | ||
pip3 freeze -r requirements-top-level.txt > requirements.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I swear I made this change at one point, must have gotten lost locally sorry about that.
lindsey-w
pushed a commit
that referenced
this pull request
Sep 24, 2020
* updated the installation instructions * tweaked wording * support the reports field * moved from list to dict * ran formatting
kbroughton
added a commit
to kbroughton/panther-analysis
that referenced
this pull request
Jul 22, 2022
fix: S3 malicious access allow panther roles from AWS (panther-labs#450)
natezpanther
added a commit
that referenced
this pull request
Jan 25, 2023
* T1499:TA0040 Endpoint DoS Query + Detection * Fixing the linter * Linter fix #2 * Linter fix #3 * Linter fix #4 * Linter fix #5 * Linter Fix #6 * Added highest_count dictionary to reduce false positives * Fixing get_key() * Disabling detection prior to merge Co-authored-by: Nate Zemanek <natezemanek@US-ML40NMGH9Q.localdomain> Co-authored-by: Nate Zemanek <natezemanek@US-ML40NMGH9Q.local>
melenevskyi
pushed a commit
that referenced
this pull request
Dec 12, 2023
* Sorted testing (#1) Add command-line argument sort-test-results to panther_analysis_tool When set,sort-test-results will bucket test results output by passed/errored status, and will sort test cases by Rule ID * Minor updates - rename variable, conditional print (#2) * Print passed tests first, followed by failed * Sort tests by Rule ID * Add container * Add container * Add container * Add logic to print organized output when a results container is passed. * Add container * Update version * Update version * Update version * Update version * Update version * Update version * Update version * Update version * Update version * Update version * Update version * Update version * Update version * Update version * Update version * Update version * Update version * Update version * Update version * Update version * Update version * Update version * rename variable. Only print detection ID in setup_run_tests when not sorting test results * Conditionally print blank lines (#3) * Conditionally print blank line * Conditionally print blank line * Use implied bool arg (#4) * Conditionally print blank line * Conditionally print blank line * Update arg implementation * Update arg implementation * Apply diff from Panther (#5) * Apply diff from panther * Lint with black (#6) * lint with black --------- Co-authored-by: Chris Dzombak <chris@chrisdzombak.net> Co-authored-by: Evan Gibler <evan.gibler@panther.com>
egibs
pushed a commit
that referenced
this pull request
Jan 16, 2024
arielkr256
added a commit
that referenced
this pull request
Jan 16, 2024
risto-liftoff
pushed a commit
to risto-liftoff/panther-analysis
that referenced
this pull request
Feb 29, 2024
* Snowflake Query Updates p2 (panther-labs#718) * Snowflake Query Updates p2 * fixing select on admin assigned query * fixing tabs to spaces * Query Fix: Making sure queries use fqtn (panther-labs#719) * query fix: fqtn (panther-labs#720) * gcp bigquery detections (panther-labs#716) * gcp bigquery large query detection * gcp destructive query detection * gcp logging settings modified detection * gcp cloud storage buckets modified or deleted (panther-labs#721) * gcp cloud storage modified or deleted * Double quote names and IDs the way that bulk download does (panther-labs#724) * Added force ttl check option to kv-table functions (panther-labs#725) * added force ttl check functionality to kv-table functions * linting & formatting * pr comment * add ttl column to get requests where missing * Snowflake queries minor fixes (panther-labs#728) * feat: Snyk detections for OU changes and external access changes (panther-labs#729) Co-authored-by: calkim-panther <113376708+calkim-panther@users.noreply.github.com> * Updated Atlassian impersonation detection displayname (panther-labs#730) Co-authored-by: Ed <ed.anderson@panther.io> --------- Co-authored-by: andrea-youwakim <117778222+andrea-youwakim@users.noreply.github.com> Co-authored-by: calkim-panther <113376708+calkim-panther@users.noreply.github.com> Co-authored-by: Dana Katzenelson <dekatzenel@gmail.com> Co-authored-by: Nick Hakmiller <49166439+nhakmiller@users.noreply.github.com> Co-authored-by: Ed <ed.anderson@panther.io> Co-authored-by: mbellifa <mohammed.bellifa@gmail.com> Co-authored-by: GH Action - Upstream Sync <action@github.com> Co-authored-by: Nick Chapman <61939106+nickchap@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
I found a bug in one of our policies, which spawned the remainder changes
Changes
Testing