Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed suffix from Log types #4

Merged
merged 1 commit into from
Jan 21, 2020
Merged

Removed suffix from Log types #4

merged 1 commit into from
Jan 21, 2020

Conversation

kostaspap
Copy link
Contributor

@kostaspap kostaspap commented Jan 20, 2020

Background

The .Log suffix has been removed from log types (it was redundant)
Updating the default rules so that they don't include the .Log suffix

Changes

Find & Remove .Logoccurences

@nhakmiller Not sure how to create a new release of the rules. I'll need your help for it once this is merged.

Copy link
Contributor

@nhakmiller nhakmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I can release & bundle a new version.

@kostaspap kostaspap merged commit 39ee57b into master Jan 21, 2020
@kostaspap kostaspap deleted the fixRules branch January 21, 2020 15:46
kbroughton added a commit to kbroughton/panther-analysis that referenced this pull request Jul 22, 2022
natezpanther pushed a commit that referenced this pull request Jan 6, 2023
nkulig pushed a commit that referenced this pull request Jan 9, 2023
natezpanther added a commit that referenced this pull request Jan 25, 2023
* T1499:TA0040 Endpoint DoS Query + Detection

* Fixing the linter

* Linter fix #2

* Linter fix #3

* Linter fix #4

* Linter fix #5

* Linter Fix #6

* Added highest_count dictionary to reduce false positives

* Fixing get_key()

* Disabling detection prior to merge

Co-authored-by: Nate Zemanek <natezemanek@US-ML40NMGH9Q.localdomain>
Co-authored-by: Nate Zemanek <natezemanek@US-ML40NMGH9Q.local>
melenevskyi pushed a commit that referenced this pull request Dec 12, 2023
* Sorted testing (#1)

Add command-line argument sort-test-results to panther_analysis_tool
When set,sort-test-results will bucket test results output by passed/errored status, and will sort test cases by Rule ID

* Minor updates - rename variable, conditional print (#2)

* Print passed tests first, followed by failed

* Sort tests by Rule ID

* Add container

* Add container

* Add container

* Add logic to print organized output when a results container is passed.

* Add container

* Update version

* Update version

* Update version

* Update version

* Update version

* Update version

* Update version

* Update version

* Update version

* Update version

* Update version

* Update version

* Update version

* Update version

* Update version

* Update version

* Update version

* Update version

* Update version

* Update version

* Update version

* Update version

* rename variable. Only print detection ID in setup_run_tests when not sorting test results

* Conditionally print blank lines (#3)

* Conditionally print blank line

* Conditionally print blank line

* Use implied bool arg (#4)

* Conditionally print blank line

* Conditionally print blank line

* Update arg implementation

* Update arg implementation

* Apply diff from Panther (#5)

* Apply diff from panther

* Lint with black (#6)

* lint with black

---------

Co-authored-by: Chris Dzombak <chris@chrisdzombak.net>
Co-authored-by: Evan Gibler <evan.gibler@panther.com>
risto-liftoff pushed a commit to risto-liftoff/panther-analysis that referenced this pull request Feb 29, 2024
…anther-labs#4)

* [Lacework Passthru] Create passthru rule to surface Lacework alerts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants