-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed suffix from Log types #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rleighton
approved these changes
Jan 20, 2020
nhakmiller
approved these changes
Jan 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I can release & bundle a new version.
kbroughton
added a commit
to kbroughton/panther-analysis
that referenced
this pull request
Jul 22, 2022
Merge in upstream master
natezpanther
added a commit
that referenced
this pull request
Jan 25, 2023
* T1499:TA0040 Endpoint DoS Query + Detection * Fixing the linter * Linter fix #2 * Linter fix #3 * Linter fix #4 * Linter fix #5 * Linter Fix #6 * Added highest_count dictionary to reduce false positives * Fixing get_key() * Disabling detection prior to merge Co-authored-by: Nate Zemanek <natezemanek@US-ML40NMGH9Q.localdomain> Co-authored-by: Nate Zemanek <natezemanek@US-ML40NMGH9Q.local>
melenevskyi
pushed a commit
that referenced
this pull request
Dec 12, 2023
* Sorted testing (#1) Add command-line argument sort-test-results to panther_analysis_tool When set,sort-test-results will bucket test results output by passed/errored status, and will sort test cases by Rule ID * Minor updates - rename variable, conditional print (#2) * Print passed tests first, followed by failed * Sort tests by Rule ID * Add container * Add container * Add container * Add logic to print organized output when a results container is passed. * Add container * Update version * Update version * Update version * Update version * Update version * Update version * Update version * Update version * Update version * Update version * Update version * Update version * Update version * Update version * Update version * Update version * Update version * Update version * Update version * Update version * Update version * Update version * rename variable. Only print detection ID in setup_run_tests when not sorting test results * Conditionally print blank lines (#3) * Conditionally print blank line * Conditionally print blank line * Use implied bool arg (#4) * Conditionally print blank line * Conditionally print blank line * Update arg implementation * Update arg implementation * Apply diff from Panther (#5) * Apply diff from panther * Lint with black (#6) * lint with black --------- Co-authored-by: Chris Dzombak <chris@chrisdzombak.net> Co-authored-by: Evan Gibler <evan.gibler@panther.com>
risto-liftoff
pushed a commit
to risto-liftoff/panther-analysis
that referenced
this pull request
Feb 29, 2024
…anther-labs#4) * [Lacework Passthru] Create passthru rule to surface Lacework alerts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The
.Log
suffix has been removed from log types (it was redundant)Updating the default rules so that they don't include the
.Log
suffixChanges
Find & Remove
.Log
occurences@nhakmiller Not sure how to create a new release of the rules. I'll need your help for it once this is merged.