Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the check_labels CI job to run concurrently with other jobs #16806

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

stuhood
Copy link
Member

@stuhood stuhood commented Sep 9, 2022

Now that Github Actions supports a "Re-run only failed jobs" option, the check_labels job no longer needs to block all other jobs, and can instead just block the "Merge OK" job.

This will give non-Contributor-contributors quicker feedback on their PRs (since they can't add labels themselves).

[ci skip-rust]

@stuhood stuhood added the category:internal CI, fixes for not-yet-released features, etc. label Sep 9, 2022
@stuhood
Copy link
Member Author

stuhood commented Sep 9, 2022

I skipped adding a label initially on this PR to confirm that this is working.

@stuhood stuhood changed the title All the check_labels CI job to run concurrently with other jobs Allow the check_labels CI job to run concurrently with other jobs Sep 9, 2022
@stuhood stuhood enabled auto-merge (squash) September 9, 2022 19:51
@stuhood stuhood enabled auto-merge (squash) September 10, 2022 02:02
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to the reasoning of helping contributors w/o perms to add labels

@stuhood stuhood merged commit df5f0ab into pantsbuild:main Sep 12, 2022
@stuhood stuhood deleted the stuhood/parallel-check-labels branch September 12, 2022 19:01
benjyw pushed a commit to benjyw/pants that referenced this pull request Oct 13, 2022
…antsbuild#16806)

Now that Github Actions supports a "Re-run only failed jobs" option, the `check_labels` job no longer needs to block all other jobs, and can instead just block the "Merge OK" job.

This will give non-`Contributor`-contributors quicker feedback on their PRs (since they can't add labels themselves).

[ci skip-rust]
benjyw added a commit that referenced this pull request Oct 14, 2022
Cherrypicks of #17218, #17169, #17194, #17172, #16806, #16796. 

Since this branch is still being released from, we want it to benefit from recent and upcoming CI improvements.

Cherry-picking them all in one PR saves on CI resources and time. And since no Pants source code is modified, only CI config, it seems fine to not cherry-pick separately.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:internal CI, fixes for not-yet-released features, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants