A general mechanism for classifying CI changes #17218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjyw
force-pushed
the
classify_changed_files
branch
3 times, most recently
from
da7e81d
to
81ee8f9
Compare
benjyw
force-pushed
the
classify_changed_files
branch
from
81ee8f9
to
b7a32a8
Compare
benjyw
changed the title
stuhood
approved these changes
Oct 13, 2022
Comment on lines
124
to
135
| if [[ "${i}" == "docs" ]]; then | ||
| echo '::set-output name=docs::true' | ||
| fi | ||
| if [[ "${i}" == "rust" ]]; then | ||
| echo '::set-output name=rust::true' | ||
| fi | ||
| if [[ "${i}" == "release" ]]; then | ||
| echo '::set-output name=release::true' | ||
| fi | ||
| if [[ "${i}" == "ci_config" ]]; then | ||
| echo '::set-output name=ci_config::true' | ||
| fi |
There was a problem hiding this comment.
Suggested change
| if [[ "${i}" == "docs" ]]; then | |
| echo '::set-output name=docs::true' | |
| fi | |
| if [[ "${i}" == "rust" ]]; then | |
| echo '::set-output name=rust::true' | |
| fi | |
| if [[ "${i}" == "release" ]]; then | |
| echo '::set-output name=release::true' | |
| fi | |
| if [[ "${i}" == "ci_config" ]]; then | |
| echo '::set-output name=ci_config::true' | |
| fi | |
| echo "::set-output name=${i}::true" |
benjyw
added a commit
to benjyw/pants
that referenced
this pull request
Oct 13, 2022
Generalizes our "docs_only" mechanism to other categories of affected things: - "rust" - "release" - "ci_config" - "docs_only" - "docs" Currently sets, but does not act on, any of these except docs_only. Future changes will apply the other categories in useful ways.
benjyw
added a commit
that referenced
this pull request
Oct 14, 2022
Cherrypicks of #17218, #17169, #17194, #17172, #16806, #16796. Since this branch is still being released from, we want it to benefit from recent and upcoming CI improvements. Cherry-picking them all in one PR saves on CI resources and time. And since no Pants source code is modified, only CI config, it seems fine to not cherry-pick separately.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalizes our "docs_only" mechanism to other categories of affected things:
Currently sets, but does not act on, any of these except docs_only.
Future changes will apply the other categories in useful ways.