Cherrypicks of recent CI improvements to 2.14.x #17222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…antsbuild#16806) Now that Github Actions supports a "Re-run only failed jobs" option, the `check_labels` job no longer needs to block all other jobs, and can instead just block the "Merge OK" job. This will give non-`Contributor`-contributors quicker feedback on their PRs (since they can't add labels themselves). [ci skip-rust]
We were previously using ${{ expr }} in f-strings, which
caused them to emit ${ expr } into the YAML, which is incorrect.
Correctly quoting this in an f-string would require 4 braces,
which is unwieldy. Plus, it's common while editing to turn a
regular string into an f-string or vice versa, and it would be
very easy to neglect to change the quoting as needed.
Instead, we introduce a helper function and use it exclusively.
Note that this bug caused us to generate useless, constant keys
for the GHA cache - in fact I noticed something was awry when
I saw CI builds re-building rust code after a successful cache
restore. Good thing our rust bootstrapping script is defensive.
I'd say we were pretty lucky if the only impact was performance;
This could potentially have lead us to actively step on our own
toes in bad ways.
…nged-files actions (pantsbuild#17194) Since the older version use a deprecated NodeJS version.
It will automatically use correct keys and take care of trimming the cache entries. However, we first had to patch that action to not wipe ~/.cargo/bin, see Swatinem/rust-cache@master...benjyw:rust-cache:master I will send that patch, or similar, upstream for consideration, so that in the future we can use the standard action instead of the forked one.
Generalizes our "docs_only" mechanism to other categories of affected things: - "rust" - "release" - "ci_config" - "docs_only" - "docs" Currently sets, but does not act on, any of these except docs_only. Future changes will apply the other categories in useful ways.
|
Each individual commit is one cherry-pick, if that makes this easier to review. |
stuhood
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypicks of #17218, #17169, #17194, #17172, #16806, #16796.
Since this branch is still being released from, we want it to benefit from recent and upcoming CI improvements.
Cherry-picking them all in one PR saves on CI resources and time. And since no Pants source code is modified, only CI config, it seems fine to not cherry-pick separately.