Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherrypicks of recent CI improvements to 2.14.x #17222

Merged
merged 6 commits into from
Oct 14, 2022
Merged

Cherrypicks of recent CI improvements to 2.14.x #17222

merged 6 commits into from
Oct 14, 2022

Commits on Oct 13, 2022

  1. Skip CI for user list changes (pantsbuild#16796)

    @benjyw
    benjyw committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    b8aeea0 View commit details
    Browse the repository at this point in the history

  2. Allow the check_labels CI job to run concurrently with other jobs (p… 

    …antsbuild#16806)

Now that Github Actions supports a "Re-run only failed jobs" option, the `check_labels` job no longer needs to block all other jobs, and can instead just block the "Merge OK" job.

This will give non-`Contributor`-contributors quicker feedback on their PRs (since they can't add labels themselves).

[ci skip-rust]
    @stuhood @benjyw
    stuhood authored and benjyw committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    9d57bfb View commit details
    Browse the repository at this point in the history

  3. Fix quoting of GitHub Actions expressions. (pantsbuild#17172) 

    We were previously using ${{ expr }} in f-strings, which
caused them to emit ${ expr } into the YAML, which is incorrect.

Correctly quoting this in an f-string would require 4 braces,
which is unwieldy. Plus, it's common while editing to turn a
regular string into an f-string or vice versa, and it would be
very easy to neglect to change the quoting as needed.

Instead, we introduce a helper function and use it exclusively.

Note that this bug caused us to generate useless, constant keys
for the GHA cache - in fact I noticed something was awry when
I saw CI builds re-building rust code after a successful cache
restore. Good thing our rust bootstrapping script is defensive.
I'd say we were pretty lucky if the only impact was performance;
This could potentially have lead us to actively step on our own
toes in bad ways.
    @benjyw
    benjyw committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    920e590 View commit details
    Browse the repository at this point in the history

  4. Update to latest version of the github-action-required-labels and cha… 

    …nged-files actions (pantsbuild#17194)

Since the older version use a deprecated NodeJS version.
    @asherf @benjyw
    asherf authored and benjyw committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    b79603f View commit details
    Browse the repository at this point in the history

  5. Use a standard Cargo caching action (pantsbuild#17169) 

    It will automatically use correct keys and take care of trimming the cache entries.

However, we first had to patch that action to not wipe ~/.cargo/bin, see
Swatinem/rust-cache@master...benjyw:rust-cache:master

I will send that patch, or similar, upstream for consideration, so that in the future we can
use the standard action instead of the forked one.
    @benjyw
    benjyw committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    5c2d2a3 View commit details
    Browse the repository at this point in the history

  6. A general mechanism for classifying CI changes (pantsbuild#17218) 

    Generalizes our "docs_only" mechanism to other categories of affected things: 
- "rust"
- "release"
- "ci_config"
- "docs_only"
- "docs"

Currently sets, but does not act on, any of these except docs_only. 
Future changes will apply the other categories in useful ways.
    @benjyw
    benjyw committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    14483cc View commit details
    Browse the repository at this point in the history