This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 379
Polkadot companion #6603: Use a BoundedVec
in ValidationResult
#2161
Merged
paritytech-processbot
merged 10 commits into
master
from
mrcnski/boundedvec-validationresult-companion
Feb 16, 2023
Merged
Polkadot companion #6603: Use a BoundedVec
in ValidationResult
#2161
paritytech-processbot
merged 10 commits into
master
from
mrcnski/boundedvec-validationresult-companion
Feb 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrcnski
added
B0-silent
Changes should not be mentioned in any release notes
A0-please_review
Pull request needs code review.
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
labels
Feb 5, 2023
3 tasks
bkchr
approved these changes
Feb 6, 2023
s0me0ne-unkn0wn
approved these changes
Feb 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
s0me0ne-unkn0wn
approved these changes
Feb 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unwrap()
is okay in tests, but it's still better like this.
Waiting for commit status. |
paritytech-processbot
bot
deleted the
mrcnski/boundedvec-validationresult-companion
branch
February 16, 2023 15:50
ordian
added a commit
that referenced
this pull request
Feb 27, 2023
* master: (35 commits) add turboflakes system-chains bootnodes (#2223) Companion for #13349 (#2217) bump `zombienet` version to v1.3.35 (#2226) [ci] Return benchmark to bm machines (#2225) Collectives chain xcm filter (#2222) Add metaspan.io parachain boot nodes (#2218) Companion for #13390 (#2189) `BlockId` removal: `BlockBuilderProvider::new_block_at` (#2219) Benchmarks script improvements (#2214) `BlockId` removal: refactor of runtime API (#2190) Rename .feature extension to .zndsl (#2215) Companion for paritytech/polkadot#6744: Retire `OldV1SessionInfo` (#2213) WIP: Fix templates (#2204) Add stake.plus bootnodes to collectives-westend and bridge-hub-kusama (#2201) Polkadot companion #6603: Use a `BoundedVec` in `ValidationResult` (#2161) Bump clap from 4.1.4 to 4.1.6 (#2193) Bump toml from 0.6.0 to 0.7.2 (#2170) companion for paritytech/polkadot#6161 (#2151) Bump serde_json from 1.0.92 to 1.0.93 (#2175) add warp_sync_params (#1909) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion for paritytech/polkadot#6603