Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

bump zombienet version to v1.3.35 #2226

Merged
merged 2 commits into from
Feb 23, 2023
Merged

bump zombienet version to v1.3.35 #2226

merged 2 commits into from
Feb 23, 2023

Conversation

pepoviola
Copy link
Contributor

Bump zombienet version and removing the is up assertions since that is now checked by zombienet before running the tests.

Thanks!

@pepoviola pepoviola added B0-silent Changes should not be mentioned in any release notes A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. labels Feb 23, 2023
@pepoviola pepoviola requested a review from a team as a code owner February 23, 2023 13:28
@paritytech-ci paritytech-ci requested a review from a team February 23, 2023 13:29
@skunert
Copy link
Contributor

skunert commented Feb 23, 2023

Nice! What is the exact logic after this change? When are the nodes considered "not up"?

Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ❤️

@pepoviola
Copy link
Contributor Author

Nice! What is the exact logic after this change? When are the nodes considered "not up"?

We move the is up check to the spawning phase, so the test-runner will start only if all the nodes are up (this means that the prometheus server of the node is reachable).

Thanks!

@paritytech-ci paritytech-ci requested a review from a team February 23, 2023 15:49
@pepoviola pepoviola merged commit af0104f into master Feb 23, 2023
@pepoviola pepoviola deleted the zn-bump-version branch February 23, 2023 16:49
ordian added a commit that referenced this pull request Feb 27, 2023
* master: (35 commits)
  add turboflakes system-chains bootnodes (#2223)
  Companion for #13349 (#2217)
  bump `zombienet` version to v1.3.35 (#2226)
  [ci] Return benchmark to bm machines (#2225)
  Collectives chain xcm filter (#2222)
  Add metaspan.io parachain boot nodes (#2218)
  Companion for #13390 (#2189)
  `BlockId` removal: `BlockBuilderProvider::new_block_at` (#2219)
  Benchmarks script improvements (#2214)
  `BlockId` removal: refactor of runtime API (#2190)
  Rename .feature extension to .zndsl (#2215)
  Companion for paritytech/polkadot#6744: Retire `OldV1SessionInfo` (#2213)
  WIP: Fix templates (#2204)
  Add stake.plus bootnodes to collectives-westend and bridge-hub-kusama (#2201)
  Polkadot companion #6603: Use a `BoundedVec` in `ValidationResult` (#2161)
  Bump clap from 4.1.4 to 4.1.6 (#2193)
  Bump toml from 0.6.0 to 0.7.2 (#2170)
  companion for paritytech/polkadot#6161 (#2151)
  Bump serde_json from 1.0.92 to 1.0.93 (#2175)
  add warp_sync_params (#1909)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants