Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Rename .feature extension to .zndsl #2215

Merged
merged 2 commits into from
Feb 20, 2023

Conversation

wirednkod
Copy link
Contributor

For alignment purposes (and in order to finalize this issue in ZombieNet repo, its preferable to rename all .feature files to .zndsl which is the preferable extension for test configs of zombienet

@wirednkod wirednkod added B0-silent Changes should not be mentioned in any release notes A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Feb 20, 2023
@tdimitrov
Copy link
Contributor

Looks good. Will the CI still execute them after the rename (I've got no idea if it relies on the filenames).

@wirednkod
Copy link
Contributor Author

Looks good. Will the CI still execute them after the rename (I've got no idea if it relies on the filenames).

Good catch. I see here that the .zndsl is used, though here .feature is mentioned. I'm not sure where to change that though

@ggwpez
Copy link
Member

ggwpez commented Feb 20, 2023

--test="0001-sync_blocks_from_tip_without_connected_collator.feature"
for example

@pepoviola
Copy link
Contributor

Yes, you need to change the filename in the pipeline definition.

Thanks!

@wirednkod
Copy link
Contributor Author

--test="0001-sync_blocks_from_tip_without_connected_collator.feature"

for example

Thank you so much. Will push the change now!

@wirednkod wirednkod requested review from a team as code owners February 20, 2023 20:00
@bkchr bkchr merged commit c0ac6a9 into master Feb 20, 2023
@bkchr bkchr deleted the nik-rename-zombienet-feature-to-zndsl branch February 20, 2023 22:20
ordian added a commit that referenced this pull request Feb 27, 2023
* master: (35 commits)
  add turboflakes system-chains bootnodes (#2223)
  Companion for #13349 (#2217)
  bump `zombienet` version to v1.3.35 (#2226)
  [ci] Return benchmark to bm machines (#2225)
  Collectives chain xcm filter (#2222)
  Add metaspan.io parachain boot nodes (#2218)
  Companion for #13390 (#2189)
  `BlockId` removal: `BlockBuilderProvider::new_block_at` (#2219)
  Benchmarks script improvements (#2214)
  `BlockId` removal: refactor of runtime API (#2190)
  Rename .feature extension to .zndsl (#2215)
  Companion for paritytech/polkadot#6744: Retire `OldV1SessionInfo` (#2213)
  WIP: Fix templates (#2204)
  Add stake.plus bootnodes to collectives-westend and bridge-hub-kusama (#2201)
  Polkadot companion #6603: Use a `BoundedVec` in `ValidationResult` (#2161)
  Bump clap from 4.1.4 to 4.1.6 (#2193)
  Bump toml from 0.6.0 to 0.7.2 (#2170)
  companion for paritytech/polkadot#6161 (#2151)
  Bump serde_json from 1.0.92 to 1.0.93 (#2175)
  add warp_sync_params (#1909)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants