Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaybeConsideration extension trait for Consideration #5384

Merged
merged 5 commits into from
Aug 26, 2024

Conversation

muharem
Copy link
Contributor

@muharem muharem commented Aug 16, 2024

Introduce MaybeConsideration extension trait for Consideration.

The trait allows for the management of tickets that may represent no cost. While the MaybeConsideration still requires proper handling, it introduces the ability to determine if a ticket represents no cost and can be safely forgotten without any side effects.

The new trait is particularly useful when a consumer expects the cost to be zero under certain conditions (e.g., when the proposal count is below a threshold N) and does not want to store such consideration tickets in storage. The extension approach allows us to avoid breaking changes to the existing trait and to continue using it as a non-optional version for migrating pallets that utilize the Currency and fungible traits for holds and freezes, without requiring any storage migration.

@muharem muharem requested a review from a team as a code owner August 16, 2024 12:40
@muharem muharem changed the title Introduce MaybeConsideration extension trait for Consideration MaybeConsideration extension trait for Consideration Aug 16, 2024
@muharem muharem added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Aug 16, 2024
@muharem muharem added this pull request to the merge queue Aug 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 26, 2024
@muharem muharem added this pull request to the merge queue Aug 26, 2024
Merged via the queue into master with commit ad0de74 Aug 26, 2024
188 of 189 checks passed
@muharem muharem deleted the muharem-maybe-consideration branch August 26, 2024 13:54
ordian added a commit that referenced this pull request Aug 27, 2024
* master: (36 commits)
  Bump the ci_dependencies group across 1 directory with 2 updates (#5401)
  Remove deprecated calls in cumulus-parachain-system (#5439)
  Make the PR template a default for new PRs (#5462)
  Only log the propagating transactions when they are not empty (#5424)
  [CI] Fix SemVer check base commit (#5361)
  Sync status refactoring (#5450)
  Add build options to the srtool build step (#4956)
  `MaybeConsideration` extension trait for `Consideration` (#5384)
  Skip slot before creating inherent data providers during major sync (#5344)
  Add symlinks for code of conduct and contribution guidelines (#5447)
  pallet-collator-selection: correctly register weight in `new_session` (#5430)
  Derive `Clone` on `EncodableOpaqueLeaf` (#5442)
  Moving `Find FAIL-CI` check to GHA (#5377)
  Remove panic, as proof is invalid. (#5427)
  Reactive syncing metrics (#5410)
  [bridges] Prune messages from confirmation tx body, not from the on_idle (#5006)
  Change the chain to Rococo in the parachain template Zombienet config (#5279)
  Improve the appearance of crates on `crates.io` (#5243)
  Add initial version of `pallet_revive` (#5293)
  Update OpenZeppelin template documentation (#5398)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants