-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pallet-collator-selection: correctly register weight in new_session
#5430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moliholy
changed the title
pallet-collator-staking: ese correctly the WeightInfo call for
pallet-collator-staking: use correctly the WeightInfo call for Aug 21, 2024
new_session
new_session
Moliholy
changed the title
pallet-collator-staking: use correctly the WeightInfo call for
pallet-collator-staking: use correctly the WeightInfo call for new_session
Aug 21, 2024
new_session
Moliholy
changed the title
pallet-collator-staking: use correctly the WeightInfo call for new_session
pallet-collator-selection: use correctly the WeightInfo call for new_session
Aug 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! A couple of comments but otherwise looks good.
georgepisaltu
added
the
T2-pallets
This PR/Issue is related to a particular pallet.
label
Aug 21, 2024
georgepisaltu
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the PR title as well.
Moliholy
changed the title
pallet-collator-selection: use correctly the WeightInfo call for new_session
pallet-collator-selection: correctly register weight in Aug 21, 2024
new_session
Done! |
joepetrowski
approved these changes
Aug 21, 2024
acatangiu
approved these changes
Aug 21, 2024
bkchr
approved these changes
Aug 24, 2024
Merged
via the queue into
paritytech:master
with commit Aug 24, 2024
475432f
226 of 230 checks passed
ordian
added a commit
that referenced
this pull request
Aug 27, 2024
* master: (36 commits) Bump the ci_dependencies group across 1 directory with 2 updates (#5401) Remove deprecated calls in cumulus-parachain-system (#5439) Make the PR template a default for new PRs (#5462) Only log the propagating transactions when they are not empty (#5424) [CI] Fix SemVer check base commit (#5361) Sync status refactoring (#5450) Add build options to the srtool build step (#4956) `MaybeConsideration` extension trait for `Consideration` (#5384) Skip slot before creating inherent data providers during major sync (#5344) Add symlinks for code of conduct and contribution guidelines (#5447) pallet-collator-selection: correctly register weight in `new_session` (#5430) Derive `Clone` on `EncodableOpaqueLeaf` (#5442) Moving `Find FAIL-CI` check to GHA (#5377) Remove panic, as proof is invalid. (#5427) Reactive syncing metrics (#5410) [bridges] Prune messages from confirmation tx body, not from the on_idle (#5006) Change the chain to Rococo in the parachain template Zombienet config (#5279) Improve the appearance of crates on `crates.io` (#5243) Add initial version of `pallet_revive` (#5293) Update OpenZeppelin template documentation (#5398) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pallet-collator-selection
is not correctly using the weight for the new_session function.The first parameter is the removed candidates, and the second one the original number of candidates before the removal, but both values are swapped.