Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add symlinks for code of conduct and contribution guidelines #5447

Merged
merged 2 commits into from
Aug 25, 2024
Merged

Add symlinks for code of conduct and contribution guidelines #5447

merged 2 commits into from
Aug 25, 2024

Conversation

rzadp
Copy link
Contributor

@rzadp rzadp commented Aug 23, 2024

Addresses this.

Another side note is the checkmarks in https://github.com/paritytech/polkadot-sdk/community. It seems like even though we have CONTRIBUTING.md in /docs it is not picked up in this list. I am not even sure what is the benefit of following these standards, but it is probably for the best to do it.

@rzadp rzadp added the R0-silent Changes should not be mentioned in any release notes label Aug 23, 2024
@rzadp rzadp mentioned this pull request Aug 23, 2024
Open
kianenigma
kianenigma reviewed Aug 23, 2024
View reviewed changes
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we can also do it for PR template?

@rzadp rzadp requested review from a team as code owners August 23, 2024 13:03
@rzadp
Copy link
Contributor Author

rzadp commented Aug 23, 2024

Seems like we can also do it for PR template?

Yes, done.

@bkchr bkchr enabled auto-merge August 25, 2024 22:19
@bkchr bkchr added this pull request to the merge queue Aug 25, 2024
Merged via the queue into master with commit 91b5a49 Aug 25, 2024
188 of 191 checks passed
@bkchr bkchr deleted the rzadp/contrib branch August 25, 2024 22:55
@rzadp rzadp mentioned this pull request Aug 26, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Aug 27, 2024
@rzadp
Make the PR template a default for new PRs (#5462)
5a84374 
A follow-up to #5447

Instead of having an option to select a PR template (like is the case
with issues), this change will make the one PR template we have the
default, it will show up for every new PR.

Also updated one link so it works properly in the PR body.
ordian added a commit that referenced this pull request Aug 27, 2024
@ordian
Merge branch 'master' into ao-fix-backing-filtering-on-disputes
26dcc0c 
* master: (36 commits)
  Bump the ci_dependencies group across 1 directory with 2 updates (#5401)
  Remove deprecated calls in cumulus-parachain-system (#5439)
  Make the PR template a default for new PRs (#5462)
  Only log the propagating transactions when they are not empty (#5424)
  [CI] Fix SemVer check base commit (#5361)
  Sync status refactoring (#5450)
  Add build options to the srtool build step (#4956)
  `MaybeConsideration` extension trait for `Consideration` (#5384)
  Skip slot before creating inherent data providers during major sync (#5344)
  Add symlinks for code of conduct and contribution guidelines (#5447)
  pallet-collator-selection: correctly register weight in `new_session` (#5430)
  Derive `Clone` on `EncodableOpaqueLeaf` (#5442)
  Moving `Find FAIL-CI` check to GHA (#5377)
  Remove panic, as proof is invalid. (#5427)
  Reactive syncing metrics (#5410)
  [bridges] Prune messages from confirmation tx body, not from the on_idle (#5006)
  Change the chain to Rococo in the parachain template Zombienet config (#5279)
  Improve the appearance of crates on `crates.io` (#5243)
  Add initial version of `pallet_revive` (#5293)
  Update OpenZeppelin template documentation (#5398)
  ...
@bkchr bkchr mentioned this pull request Sep 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kianenigma kianenigma kianenigma approved these changes

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rzadp @kianenigma @bkchr