Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add layout-restricting parameters to BaseDevice #751

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

HGSilveri
Copy link
Collaborator

  • Adds three new layout-specific parameters to BaseDevice:
    • optimal_layout_filling: An optional value for the fraction of a layout that should be filled with atoms.
    • min_layout_traps: The minimum number of traps a layout can have.
    • max_layout_traps: An optional value for the maximum number of traps a layout can have.
  • Includes these new values in BaseDevice.validate_layout()

Closes #749 .

@HGSilveri HGSilveri requested a review from a-corni October 14, 2024 14:53
@HGSilveri HGSilveri self-assigned this Oct 14, 2024
Copy link
Collaborator

@a-corni a-corni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@HGSilveri HGSilveri merged commit a8cd6f1 into develop Oct 16, 2024
9 checks passed
@HGSilveri HGSilveri mentioned this pull request Oct 17, 2024
HGSilveri added a commit that referenced this pull request Oct 18, 2024
**Main changes**:
- Add layout restricting parameters to BaseDevice (#751) 
- Incorporate automatic layout generation in Register (#753) 

**Fixes**:
- Fix rounding error in RampWaveform (#747) 
- Fix normalisation in ring of atoms (#750)
- Improve the NoiseModel unused parameters warning message (#752)
@HGSilveri HGSilveri deleted the hs/new-device-params branch November 12, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optionally enforce a minimum and maximum number of traps in RegisterLayout
2 participants