Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the NoiseModel unused parameters warning message #752

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

HGSilveri
Copy link
Collaborator

The warning message indicating there are unused parameters in the NoiseModel now includes the non-zero noise parameters, e.g. for

pulser.NoiseModel(p_false_pos=0.1, runs=10)

Before:

UserWarning: 'runs' is not used by any active noise type ('SPAM',).

After:

UserWarning: 'runs' is not used by any active noise type in ('SPAM',) when the only defined parameters are ['p_false_pos'].

Fixes #742 .

Copy link
Collaborator

@a-corni a-corni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve, I also think it brings value to add this :)

@HGSilveri HGSilveri merged commit c6e9fbf into develop Oct 16, 2024
9 checks passed
@HGSilveri HGSilveri mentioned this pull request Oct 17, 2024
HGSilveri added a commit that referenced this pull request Oct 18, 2024
**Main changes**:
- Add layout restricting parameters to BaseDevice (#751) 
- Incorporate automatic layout generation in Register (#753) 

**Fixes**:
- Fix rounding error in RampWaveform (#747) 
- Fix normalisation in ring of atoms (#750)
- Improve the NoiseModel unused parameters warning message (#752)
@HGSilveri HGSilveri deleted the hs/noise-warning branch November 12, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants