Incorporate automatic layout generation in Register
#753
Conversation
HGSilveri
force-pushed
the
hs/arb-layout-gen
branch
from
98b7d92 to
1d8c88a
Compare
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
HGSilveri
changed the title
RegisterRegister
| min_traps, | ||
| ) | ||
| if max_traps: | ||
| target_traps = min(target_traps, max_traps) |
There was a problem hiding this comment.
Isn't it also possible that min_traps be bigger than max_traps ? Shouldn't we also have
min_traps = min(min_traps, max_traps)
There was a problem hiding this comment.
When they come from Device it's not possible; min_traps > max_traps has no solution, after all
There was a problem hiding this comment.
This function is not supposed to be user-facing so I'll just add some asserts for now
There was a problem hiding this comment.
Ah I think there was a little misunderstanding. I meant that if N_seeds is extremely big, you might have the new min_traps higher than max_traps after the np.ceil, so I guess it would be good to have
| target_traps = min(target_traps, max_traps) | |
| target_traps = min(target_traps, max_traps) | |
| min_traps = min(min_traps, max_traps) |
There was a problem hiding this comment.
I see what you mean but if you do this, the program will successfully terminate when it reach max_traps, which will be lower than what you need (min_traps before your new line). We don't want this to happen because it won't respect the max_layout_filling.
What I'll do instead is always check at the end that len(traps) >= min_traps and raise the RuntimeError otherwise.
**Main changes**: - Add layout restricting parameters to BaseDevice (#751) - Incorporate automatic layout generation in Register (#753) **Fixes**: - Fix rounding error in RampWaveform (#747) - Fix normalisation in ring of atoms (#750) - Improve the NoiseModel unused parameters warning message (#752)
Register.with_automatic_layout(device: Device), which allows the user to get an automatically generated layout that obeys thedeviceconstrains from any registerCloses #748 .