-
Notifications
You must be signed in to change notification settings - Fork 376
Closed
Description
- The navigation links currently are not accessible for either keyboard-only users or screen reader users. They can be made accessible by including a url in an
hrefattribute. (Update: given current recommendations, it might make the most sense to make the items buttons so that they are keyboard accessible- see discussion below) - In the mobile layout, the navigation is accessed as a menu. The dropdown behavior pattern that I think makes sense here currently isn't implemented anywhere yet. I included comments about similar behavior in the PRs for context selector and select components, but maybe it would make sense to have a quick chat with everyone to understand if there's a simpler way to handle this interaction so that it can be easily reused across the different components?
- Update: Ideally, the interaction pattern would be the following: https://docs.google.com/document/d/1m9nICFRgCXnXeHYN487BMX9MHw4DjvOln2B5p8yJa70/edit#heading=h.1lr7m0rc8a6s however making the menu accessible is the most important aspect.