fix(DataToolbar): fix filter context from updating unnecessarily #4056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
PF4 preview: https://patternfly-react-pr-4056.surge.sh |
kmcfaul
force-pushed
the
toolbar-max-depth
branch
from
bc68471 to
976842c
Compare
nicolethoen
previously approved these changes
Apr 13, 2020
Contributor
Author
|
@redallen Any ideas about the difference in snapshots? I can't seem to get them to update to what the build is wanting, they are passing on my machine. Maybe I have to clean a cache somewhere? |
…n chips don't change
kmcfaul
force-pushed
the
toolbar-max-depth
branch
from
976842c to
0ce9b51
Compare
dlabaj
approved these changes
Apr 14, 2020
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #3770
DataToolbar's state was getting updated by each DataToolbarFilter even when nothing was changed, so I added a check to only kick off the update when a filter's chips got updated.
Moving DataToolbar's internal
filterInfoobject out of its state, to a private variable, would be another way to resolve the bug.