Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: component paths #7246

Merged
merged 114 commits into from
Aug 5, 2024
Merged

feat!: component paths #7246

merged 114 commits into from
Aug 5, 2024

Conversation

AlessioGr
Copy link
Member

@AlessioGr AlessioGr commented Jul 19, 2024

This PR ensures that the payload config is 100% server-only. Instead of importing custom components into your config directly, they are now defined as file paths and rendered only when needed. That way, the payload 3.0 release does not rely on vercel/next.js#65415 which will likely will not get merged. Now, the Payload config will be significantly more lightweight.

Related discussion: #6938

The issue

This PR fixes a few issues:

#4085 #6598 #6441 #7261 #7339

Local API within Next.js routes

Previously, if you used the payload local API within Next.js pages, all the client-side modules are being added to the bundle for that specific page, even if you only need server-side functionality.

This /test route, which uses the payload local API, was previously 460 kb. It is now down to 91 kb and does not bundle the payload client-side admin panel anymore.

All tests done here with beta.67/PR, db-mongodb and default richtext-lexical:

dev /admin before:
CleanShot 2024-07-29 at 22 49 12@2x

dev /admin after:
CleanShot 2024-07-29 at 22 50 49@2x


dev /test before:
CleanShot 2024-07-29 at 22 56 18@2x

dev /test after:
CleanShot 2024-07-29 at 22 47 45@2x


build before:
CleanShot 2024-07-29 at 22 57 14@2x

build after::
CleanShot 2024-07-29 at 22 56 39@2x

Usage of the payload local API / config outside of Next.js

This will make it a lot easier to use the payload config / local API in other, server-side contexts. Previously, you might encounter errors due to client files (like .scss files) not being allowed to be imported.

Custom Client Components are not server-rendered anymore

Previously, custom components would be server-rendered in buildComponentMap, no matter if they are server or client components. Now, only server components are rendered in buildComponentMap. Client components simply get passed through, using MappedComponent as a container. It is then the client's responsibility to render those.

This makes rendering them on the client a little bit more complex, as you now have to check if that component is a server component (=> already has been rendered) or a client component (=> not rendered yet, has to be rendered here). However, this added complexity has been alleviated through the easy-to-use <RenderMappedComponent /> helper.

This helper now also handles rendering arrays of custom components (e.g. beforeList, beforeLogin ...), which actually makes rendering custom components easier in some cases.

The benefit of this change:

Custom client components can now receive props. Previously, the only way for them to receive dynamic props from a parent client component was to use hooks, e.g. useFieldProps(). Now, we do have the option of passing in props to the custom components directly, if they are client components. This will be simpler than having to look for the correct hook,

Misc improvements

This PR includes misc, breaking changes. For example, we previously allowed unions between components and config object for the same property. E.g. for the custom view property, you were allowed to pass in a custom component or an object with other properties, alongside a custom component.

Those union types are now gone. You can now either pass an object, or a component. The previous { View: MyViewComponent} is now { View: { Component: MyViewComponent} } or { View: { Default: { Component: MyViewComponent} } }.

This dramatically simplifies the way we read & process those properties, especially in buildComponentMap. We can now simply check for the existence of one specific property, which always has to be a component, instead of running cursed runtime checks on a shared union property which could contain a component, but could also contain functions or objects.

CleanShot 2024-07-29 at 23 07 07@2x

CleanShot 2024-07-29 at 23 09 40@2x

Custom Components

In order to reference any custom components in the payload config, you now have to specify a string path to the component instead of importing it.

E.g.

import { MyComponent2} from './MyComponent2.js'

admin: {
  components: {
    Label: MyComponent2
  },
},

Now becomes:

admin: {
  components: {
    Label: '/collections/Posts/MyComponent2.js#MyComponent2', // <= has to be a relative path based on a baseDir configured in the payload config - NOT relative based on the importing file
  },
},

Concepts: MappedComponent and PayloadComponent

Instead of React.FC / React.ComponentType, props within the payload config that accept components now accept PayloadComponent. These are basically the paths to the component. They can be a string, or an object containing other properties like serverProps and clientProps - giving you full control over the props this component will eventually receive.

MappedComponent is the result of buildComponentMap processing all those PayloadComponents. It contains the server-rendered component, or unrendered/rendered client component. Any MappedComponent can be rendered on both either the client and the server using the RenderMappedComponent helper component.

Try it out

This can be tested out here: https://github.com/payloadcms/payload-3.0-demo/tree/feat/path-test

Todo

  • Migrate all payload plugins to new import pattern & get it to build
  • Migrate test suites to new import pattern
  • Clean-up, simplify component handling within core, add JSDocs
  • Add Docs
  • Collect all breaking changes

@AlessioGr AlessioGr changed the base branch from main to beta July 19, 2024 18:57
@AlessioGr AlessioGr changed the title WIP: component paths feat!: fully server-side payload config, component paths instead of imports Jul 30, 2024
@payloadcms payloadcms deleted a comment from github-actions bot Jul 30, 2024
@jacobsfletch jacobsfletch changed the title feat!: fully server-side payload config, component paths instead of imports feat!: component paths Aug 2, 2024
@jacobsfletch jacobsfletch changed the base branch from beta to beta-prev August 5, 2024 19:56
@jacobsfletch jacobsfletch marked this pull request as ready for review August 5, 2024 19:59
@jacobsfletch jacobsfletch merged commit 670bbd1 into beta-next Aug 5, 2024
33 of 47 checks passed
@jacobsfletch jacobsfletch deleted the feat/component-paths branch August 5, 2024 20:03
@AlessioGr AlessioGr mentioned this pull request Aug 13, 2024
1 task
jacobsfletch added a commit that referenced this pull request Dec 20, 2024
The auth example was still on `v3.0.0-beta.24`, was missing its users
collection config, and was not yet using the component paths pattern
established here: #7246. This updates to latest and fixes these issues.
This example can still use further improvements and housekeeping which
will come in future PRs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants