Skip to content

Commit

Permalink
Freemius: Check _parent object for using method
Browse files Browse the repository at this point in the history
A proposed solution for an error reported in this [Slack thread](https://podswp.slack.com/archives/C02SVLHQF/p1631628235171000).

It appears that `$this->_parent` can contain either an object or a boolean.
This should resolve the error by checking that it's an object before attempting to use the method `->is_anonymous()`.

It looks like `$this->_parent` is used in other places in this class.
Unknown if the `boolean` vs. `object` detail effects any other functionality.

Error:
```
Error Details
=============
An error of type E_ERROR was caused in line 23432 of the file /home/ekhulnac/public_html/destra/plugins/pods/vendor/freemius/wordpress-sdk/includes/class-freemius.php. Error message: Uncaught Error: Call to a member function is_anonymous() on bool in /home/ekhulnac/public_html/destra/plugins/pods/vendor/freemius/wordpress-sdk/includes/class-freemius.php:23432
Stack trace:
#0 /home/ekhulnac/public_html/destra/plugins/pods/vendor/freemius/wordpress-sdk/includes/class-freemius.php(2051): Freemius->_add_tracking_links()
pods-framework#1 /home/ekhulnac/public_html/wp-includes/class-wp-hook.php(303): Freemius->_hook_action_links_and_register_account_hooks('')
pods-framework#2 /home/ekhulnac/public_html/wp-includes/class-wp-hook.php(327): WP_Hook->apply_filters(NULL, Array)
pods-framework#3 /home/ekhulnac/public_html/wp-includes/plugin.php(470): WP_Hook->do_action(Array)
pods-framework#4 /home/ekhulnac/public_html/wp-admin/admin.php(175): do_action('admin_init')
pods-framework#5 /home/ekhulnac/public_html/wp-admin/plugins.php(10): require_once('/home/ekhulnac/...')
pods-framework#6 {main}
```
  • Loading branch information
pdclark authored Sep 14, 2021
1 parent fcb491b commit 19c0fcb
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions vendor/freemius/wordpress-sdk/includes/class-freemius.php
Original file line number Diff line number Diff line change
Expand Up @@ -23429,6 +23429,7 @@ function _add_tracking_links() {
if (
$this->is_addon() &&
! $this->is_only_premium() &&
is_object( $this->_parent ) &&
$this->_parent->is_anonymous()
) {
return;
Expand Down

0 comments on commit 19c0fcb

Please sign in to comment.