Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh 2.0 with 1.12 code #4

Closed
sc0ttkclark opened this issue Sep 2, 2011 · 6 comments
Closed

Refresh 2.0 with 1.12 code #4

sc0ttkclark opened this issue Sep 2, 2011 · 6 comments
Assignees
Labels
Type: Feature Features that add entirely new functionality that was not there before
Milestone

Comments

@sc0ttkclark
Copy link
Member

No description provided.

@ghost ghost assigned sc0ttkclark Sep 2, 2011
@sc0ttkclark
Copy link
Member Author

Started on this yesterday. All that's left is syncing the classes and functions.php now.

@sc0ttkclark
Copy link
Member Author

Got it all except for the classes Pod (started but not completed) and PodAPI (PodInit is done, PodCache is still in limbo whether it'll be used in 2.0 or if we'll go all object cache / transients API)

@sc0ttkclark
Copy link
Member Author

Commited sc0ttkclark/pods@2328ab6c31d0571ab1d6c9731dd2aac76c2e6a3d

@sc0ttkclark
Copy link
Member Author

Still working on PodAPI and Pod, switched to PodAPI because it should be a little easier since not too much is new there, Pod had a lot of deprecated function names like findRecords >> find so it's a little different and I'll save that for very last.

sc0ttkclark added a commit that referenced this issue Sep 19, 2011
@sc0ttkclark
Copy link
Member Author

PodAPI done (see above commit), still have refactoring to go back through and do but the main refresh is good, working on final file Pod now.

@sc0ttkclark
Copy link
Member Author

Close with Pod class now, just gotta finish up findRecords

pdclark added a commit to pdclark/pods that referenced this issue Sep 14, 2021
A proposed solution for an error reported in this [Slack thread](https://podswp.slack.com/archives/C02SVLHQF/p1631628235171000).

It appears that `$this->_parent` can contain either an object or a boolean.
This should resolve the error by checking that it's an object before attempting to use the method `->is_anonymous()`.

It looks like `$this->_parent` is used in other places in this class.
Unknown if the `boolean` vs. `object` detail effects any other functionality.

Error:
```
Error Details
=============
An error of type E_ERROR was caused in line 23432 of the file /home/ekhulnac/public_html/destra/plugins/pods/vendor/freemius/wordpress-sdk/includes/class-freemius.php. Error message: Uncaught Error: Call to a member function is_anonymous() on bool in /home/ekhulnac/public_html/destra/plugins/pods/vendor/freemius/wordpress-sdk/includes/class-freemius.php:23432
Stack trace:
#0 /home/ekhulnac/public_html/destra/plugins/pods/vendor/freemius/wordpress-sdk/includes/class-freemius.php(2051): Freemius->_add_tracking_links()
pods-framework#1 /home/ekhulnac/public_html/wp-includes/class-wp-hook.php(303): Freemius->_hook_action_links_and_register_account_hooks('')
pods-framework#2 /home/ekhulnac/public_html/wp-includes/class-wp-hook.php(327): WP_Hook->apply_filters(NULL, Array)
pods-framework#3 /home/ekhulnac/public_html/wp-includes/plugin.php(470): WP_Hook->do_action(Array)
pods-framework#4 /home/ekhulnac/public_html/wp-admin/admin.php(175): do_action('admin_init')
pods-framework#5 /home/ekhulnac/public_html/wp-admin/plugins.php(10): require_once('/home/ekhulnac/...')
pods-framework#6 {main}
```
This was referenced May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Features that add entirely new functionality that was not there before
Projects
None yet
Development

No branches or pull requests

1 participant