Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp Form UI #2

Closed
sc0ttkclark opened this issue Sep 1, 2011 · 7 comments
Closed

Revamp Form UI #2

sc0ttkclark opened this issue Sep 1, 2011 · 7 comments
Assignees
@sc0ttkclark
Labels
Type: Feature Features that add entirely new functionality that was not there before
Milestone
Pods 2.0

Comments

@sc0ttkclark
Copy link
Member

No description provided.

@ghost ghost assigned jchristopher Sep 1, 2011
@sc0ttkclark
Copy link
Member Author

Need to put together the form for use on the frontend (publicForm replacement) and the backend (partially completed).

Should use CSS best-practices, follow what Gravity Forms does if you want inspiration. Current publicForm UI is too basic and plain, should have a bit more style to it like Gravity Forms has. New backend form should take it's cue from the WP UI for the post editor, so as much as it can retain that look the better.

@ghost ghost assigned cpilko Jan 14, 2012
@sc0ttkclark sc0ttkclark mentioned this issue Apr 26, 2012
Closed
@sc0ttkclark
Copy link
Member Author

I'm working on refactoring the Form class, so each field extends a general field class and has more options to hook into from their own custom field types. UI will also be separated out and pulled from the ui folder, which could be made to be hookable so that they could be overridden.

@sc0ttkclark
Copy link
Member Author

Wasn't able to get it to a working point to commit this weekend. I should really find a workflow that has me working from a new branch, now that 2.0 alpha is live lol.

@sc0ttkclark
Copy link
Member Author

Well looky looky, creating a new branch for my commits to go into was super easy. Not sure how that'll work with committing to existing branches, but I'll be working from 2.0-bleeding now and just do pull requests for each real alpha release.

@sc0ttkclark
Copy link
Member Author

OK so you can see a lot of the form stuff I'm doing here:

0a48014

I still have quite a bit of pulling in of each field's data, and then building out the actual field option loop in the setup_edit_field.php, which handles each individual option, setting the defaults for that option, etc. My idea for the form field classes (in /classes/fields/boolean.php) is to make it the one place to modify each field's settings for input, display, saving, and settings. Boolean and Number have been nearly completed, I've been stripping out the actual HTML into the new pods_view function and pulling from the /ui/fields/ folder now.

I should be done soon!

@sc0ttkclark
Copy link
Member Author

Notes for a later self: Build out options for boolean field, then follow that structure for other fields when building out

@sc0ttkclark
Copy link
Member Author

Need to add dependency handling into field options, and switch 'values' array to 'data', then determine grouping

@ghost ghost assigned dontfeedthecode Jul 25, 2012
This was referenced Jul 26, 2012
Closed
Closed
@sc0ttkclark sc0ttkclark mentioned this issue Oct 16, 2012
Closed
@vjanagaran vjanagaran mentioned this issue Dec 11, 2012
Closed
@sc0ttkclark sc0ttkclark mentioned this issue Feb 12, 2013
Closed
@whatwillb whatwillb mentioned this issue Mar 20, 2013
Closed
@sirbeagle sirbeagle mentioned this issue Jun 17, 2013
Closed
@guilhermevrs guilhermevrs mentioned this issue Jan 23, 2014
Closed
@ionlantern ionlantern mentioned this issue Apr 17, 2014
Closed
@etki etki mentioned this issue Oct 25, 2014
Closed
@sc0ttkclark sc0ttkclark self-assigned this Dec 29, 2015
sc0ttkclark pushed a commit that referenced this issue Jul 11, 2016
@JoryHogeveen
Merge pull request #2 from pods-framework/feature/#3364-2.7-Feature-R…
653972f 
…elease

	Merge branch 'feature/#3364-2.7-Feature-Release' into #3364-2.7-Feature-Release
@dangson dangson mentioned this issue Dec 19, 2016
Closed
@azcomps azcomps mentioned this issue Dec 1, 2017
Closed
@tanthammar tanthammar mentioned this issue Apr 7, 2018
Closed
@twohumans twohumans mentioned this issue Jul 9, 2019
Closed
@bryanhiggs bryanhiggs mentioned this issue Mar 26, 2020
Closed
@sueboothby sueboothby mentioned this issue Apr 2, 2020
Closed
@papa-pup papa-pup mentioned this issue Sep 23, 2020
Closed
pdclark added a commit to pdclark/pods that referenced this issue Sep 14, 2021
@pdclark
Freemius: Check _parent object for using method
19c0fcb 
A proposed solution for an error reported in this [Slack thread](https://podswp.slack.com/archives/C02SVLHQF/p1631628235171000).

It appears that `$this->_parent` can contain either an object or a boolean.
This should resolve the error by checking that it's an object before attempting to use the method `->is_anonymous()`.

It looks like `$this->_parent` is used in other places in this class.
Unknown if the `boolean` vs. `object` detail effects any other functionality.

Error:
```
Error Details
=============
An error of type E_ERROR was caused in line 23432 of the file /home/ekhulnac/public_html/destra/plugins/pods/vendor/freemius/wordpress-sdk/includes/class-freemius.php. Error message: Uncaught Error: Call to a member function is_anonymous() on bool in /home/ekhulnac/public_html/destra/plugins/pods/vendor/freemius/wordpress-sdk/includes/class-freemius.php:23432
Stack trace:
#0 /home/ekhulnac/public_html/destra/plugins/pods/vendor/freemius/wordpress-sdk/includes/class-freemius.php(2051): Freemius->_add_tracking_links()
pods-framework#1 /home/ekhulnac/public_html/wp-includes/class-wp-hook.php(303): Freemius->_hook_action_links_and_register_account_hooks('')
pods-framework#2 /home/ekhulnac/public_html/wp-includes/class-wp-hook.php(327): WP_Hook->apply_filters(NULL, Array)
pods-framework#3 /home/ekhulnac/public_html/wp-includes/plugin.php(470): WP_Hook->do_action(Array)
pods-framework#4 /home/ekhulnac/public_html/wp-admin/admin.php(175): do_action('admin_init')
pods-framework#5 /home/ekhulnac/public_html/wp-admin/plugins.php(10): require_once('/home/ekhulnac/...')
pods-framework#6 {main}
```
@rcrdb rcrdb mentioned this issue Nov 8, 2021
Closed
@wildmercury wildmercury mentioned this issue Nov 15, 2021
Closed
@professorseo professorseo mentioned this issue Nov 16, 2021
Closed
@mmages mmages mentioned this issue Nov 18, 2021
Closed
@DracoVenturus DracoVenturus mentioned this issue Apr 8, 2022
Closed
@bartgriffin bartgriffin mentioned this issue May 9, 2022
Closed
@ghost ghost mentioned this issue Sep 12, 2022
Closed
@mroverssi mroverssi mentioned this issue Jan 25, 2023
Closed
@what-the-diff what-the-diff bot mentioned this issue Feb 14, 2023
Merged
@mkjuergen mkjuergen mentioned this issue May 15, 2023
Open
This was referenced May 30, 2023
Closed
Closed
@JoryHogeveen JoryHogeveen mentioned this issue Jun 23, 2023
Closed
@reedtsutton reedtsutton mentioned this issue Apr 11, 2024
Draft
4 tasks
@rosa2 rosa2 mentioned this issue Jul 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sc0ttkclark sc0ttkclark

Labels
Type: Feature Features that add entirely new functionality that was not there before
Projects
None yet
Milestone
Pods 2.0
Development

No branches or pull requests
6 participants
@mikedamage @jchristopher @sc0ttkclark @cpilko @steveguberman @dontfeedthecode