-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extended status assertion errors table added #53
Extended status assertion errors table added #53
Conversation
This commit aims to resolve issue peppelinux#46.
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
"credential_hash": $CREDENTIAL-HASH, | ||
"credential_hash_alg": "sha-256", | ||
"error": "credential_revoked", | ||
"error_description": "Credential is revoked." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, the holder can never prove the credential is revoked, they can only prove if its not.
I wonder if treating revocation as an error is a good idea. I can see pro's and con's.
An alternative would be to issue an assertion that the credential was revoked, and return a different structure for errors with the request or on the server (4xx, 5xx).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please do a proposal, I would like to have draft 03 before the next interim meeting
I used status code set to 200 for two reasons:
- the result is an array with multiple embedded responses, be these assertions or errors
- adversaries won't take any behavioral information from the endpoint without inspecting the JWT/CWT contained in the response array
I want to know from you if you want a different approach or if you only want remove this error type about the already revoked credential
Co-authored-by: fmarino-ipzs <77629526+fmarino-ipzs@users.noreply.github.com>
I have improved the |
This commit aims to resolve issue #46.