generated from martinthomson/internet-draft-template
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extended status assertion errors table added #53
Merged
peppelinux
merged 21 commits into
peppelinux:main
from
SaraConsoliACN:SaraConsoliACN-status-assertion-response-errors
May 25, 2024
Merged
Changes from 15 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
b7d04f0
extended status assertion errors table added
SaraConsoliACN 62679da
RFC6749 reference added.
SaraConsoliACN f8feaa1
Merge branch 'main' into SaraConsoliACN-status-assertion-response-errors
SaraConsoliACN 3b3099a
Commit suggestion applied
SaraConsoliACN e65a50b
Apply suggestions from code review
6e04a90
New errors added
SaraConsoliACN ebece95
Apply suggestions from code review
bdec77b
Apply suggestions from code review
ce2c28a
Apply suggestions from code review
6e3684b
Apply suggestions from code review
1db6c24
Apply suggestions from code review
d942c33
Apply suggestions from code review
7bc4736
Commit suggestion applied
SaraConsoliACN 837c25a
Commit suggestion applied
SaraConsoliACN 50df835
Apply suggestions from code review
461cb6a
Apply suggestions from code review
56679ca
Apply suggestions from code review
c8081d8
Merge branch 'main' into SaraConsoliACN-status-assertion-response-errors
9383217
Apply suggestions from code review
7f47b0f
Apply suggestions from code review
104fab7
fix: trailing space
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, the holder can never prove the credential is revoked, they can only prove if its not.
I wonder if treating revocation as an error is a good idea. I can see pro's and con's.
An alternative would be to issue an assertion that the credential was revoked, and return a different structure for errors with the request or on the server (4xx, 5xx).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please do a proposal, I would like to have draft 03 before the next interim meeting
I used status code set to 200 for two reasons:
I want to know from you if you want a different approach or if you only want remove this error type about the already revoked credential