Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pex cannot correctly resolve between multiple transitive dependencies #614

Closed
tglstory opened this issue Oct 30, 2018 · 1 comment · Fixed by #788
Closed

Pex cannot correctly resolve between multiple transitive dependencies #614

tglstory opened this issue Oct 30, 2018 · 1 comment · Fixed by #788
Assignees

Comments

@tglstory
Copy link

Reproduction:
pex apache-airflow==1.10.0 --interpreter-constraint='CPython<3.7'
Pex version:
pex 1.5.1

Problem:
Above command gives output of

Could not satisfy all requirements for flask-login==0.2.11:
    flask-login==0.2.11(from: apache-airflow==1.10.0), Flask-Login<0.5,>=0.3(from: apache-airflow==1.10.0->flask-appbuilder<2.0.0,>=1.11.1)

Airflow 1.10.0's setup.py denotes flask-login of 0.2.11. https://github.com/apache/incubator-airflow/blob/1.10.0/setup.py#L280

However, it also depends on flask-appbuilder with a constraint of <2.0.0,>=1.11.1.
Looking at two different versions of flask-appbuilder:
https://github.com/dpgaspar/Flask-AppBuilder/blob/v1.11.1/setup.py#L41 vs https://github.com/dpgaspar/Flask-AppBuilder/blob/v1.12.1/setup.py#L42

1.11.1 and 1.12.1 both meet the requirement of <2.0.0,>=1.11.1 but they require incompatible versions of flask-login. Pex should be able to resolve to the earlier version and pick up flask-login 0.2.11.

@jsirois jsirois added the bug label Oct 30, 2018
@jsirois
Copy link
Member

jsirois commented Oct 30, 2018

Noting that the workaround is to specify the correct solution for Flask-AppBuilder manually:
SLUGIFY_USES_TEXT_UNIDECODE=yes pex --python=python2 'apache-airflow==1.10.0; python_version < "3.7"' Flask-AppBuilder==1.11.1.

@jsirois jsirois mentioned this issue Nov 3, 2018
@jsirois jsirois mentioned this issue Dec 6, 2018
jsirois added a commit to jsirois/pex that referenced this issue Jan 8, 2019
@jsirois jsirois assigned jsirois and unassigned jsirois Jan 8, 2019
@jsirois jsirois mentioned this issue Jan 23, 2019
3 tasks
@jsirois jsirois mentioned this issue Feb 6, 2019
2 tasks
@jsirois jsirois mentioned this issue Mar 10, 2019
3 tasks
jsirois added a commit to jsirois/pex that referenced this issue Oct 27, 2019
@jsirois jsirois self-assigned this Nov 14, 2019
jsirois added a commit that referenced this issue Nov 14, 2019
This changes Pex to vendor pip and defer all resolution and building to it.

As part of this change some ambiguous and / or broken features were changed and APIs adjusted:
+ The egg distribution format is no longer supported.
+ The deprecated `--interpreter-cache-dir` CLI option was removed.
+ The `--cache-ttl` CLI option and `cache_ttl` resolver API argument were removed.
+ The resolver API replaced `fetchers` with a list of `indexes` and a list of `find_links` repos.
+ The resolver API removed (http) `context` which is now automatically handled.
+ The resolver API removed `precedence` which is now pip default precedence - wheels when available and not ruled out via the `--no-wheel` CLI option or `use_wheel=False` API argument.
+ The `--platform` CLI option and `platform` resolver API argument now must be full platform strings that include platform, implementation, version and abi; e.g.: `--platform=macosx-10.13-x86_64-cp-36-m`.
+ The `--manylinux` CLI option and `use_manylinux` resolver API argument were removed. Instead, to resolve manylinux wheels for a foreign platform, specify the manylinux platform to use with an explicit `--platform` CLI flag or `platform` resolver API argument; e.g.: `--platform=manylinux2010-x86_64-cp-36-m`.

Fixes #781

Additionally:
Fixes #771
Fixes #763
Fixes #761
Fixes #735 
Fixes #694 
Fixes #660
Fixes #658 
Fixes #642
Fixes #641
Fixes #628
Fixes #620
Fixes #614
Fixes #611
Fixes #608
Fixes #439
Fixes #415
Fixes #387
Fixes #315
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants