-
-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency resolution can't handle PEP 503-style normalized package names #641
Comments
Thanks for pointing this out @nikhaldi - I agree we should support this. |
This was referenced Jan 8, 2019
Closed
10 tasks
jsirois
added a commit
that referenced
this issue
Nov 14, 2019
This changes Pex to vendor pip and defer all resolution and building to it. As part of this change some ambiguous and / or broken features were changed and APIs adjusted: + The egg distribution format is no longer supported. + The deprecated `--interpreter-cache-dir` CLI option was removed. + The `--cache-ttl` CLI option and `cache_ttl` resolver API argument were removed. + The resolver API replaced `fetchers` with a list of `indexes` and a list of `find_links` repos. + The resolver API removed (http) `context` which is now automatically handled. + The resolver API removed `precedence` which is now pip default precedence - wheels when available and not ruled out via the `--no-wheel` CLI option or `use_wheel=False` API argument. + The `--platform` CLI option and `platform` resolver API argument now must be full platform strings that include platform, implementation, version and abi; e.g.: `--platform=macosx-10.13-x86_64-cp-36-m`. + The `--manylinux` CLI option and `use_manylinux` resolver API argument were removed. Instead, to resolve manylinux wheels for a foreign platform, specify the manylinux platform to use with an explicit `--platform` CLI flag or `platform` resolver API argument; e.g.: `--platform=manylinux2010-x86_64-cp-36-m`. Fixes #781 Additionally: Fixes #771 Fixes #763 Fixes #761 Fixes #735 Fixes #694 Fixes #660 Fixes #658 Fixes #642 Fixes #641 Fixes #628 Fixes #620 Fixes #614 Fixes #611 Fixes #608 Fixes #439 Fixes #415 Fixes #387 Fixes #315
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
PyPI and setuptools support package name normalization as per PEP 503: https://www.python.org/dev/peps/pep-0503/#normalized-names
This means that a package like https://pypi.org/project/pytest-selenium/ can be installed both with
pip install pytest.selenium
andpip install pytest-selenium
.pex only accepts already normalized package names. If I put
pytest.selenium
in arequirements.txt
file this won't work:Same works with
pytest-selenium
.For consistency with other build tools pex should support this as well. Arguably the PEP 503 behavior is weird (I only just learned about it today too) and probably bad design. But consistency across tools might trump bad design decisions. I came across this because a user was trying an existing requirements file that had always worked for them with pip and couldn't figure out why it failed in pex.
The text was updated successfully, but these errors were encountered: