Support PEP-503 name normalization. #643
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not for review yet - this needs a test. |
|
Thanks a lot for working on this @jsirois ... I'm having a lot of success w/ this patch so far. I've monkey patched pants-1.70/pex-1.3.2 like so https://gist.github.com/JustinVenus/2fece24acfb376553a629c805ae6eace |
|
I'm not sure how I lost track of this one, but I've re-based. I'm going to sit on it though and prefer the work in #781 to fix this bug if that work is accepted. |
|
Since #781 is now merged I'm going to drop this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #641