Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for labchart files that don't have the time in the channel_list #140

Merged
merged 14 commits into from
Feb 13, 2020
Merged

Add support for labchart files that don't have the time in the channel_list #140

merged 14 commits into from
Feb 13, 2020

Conversation

vinferrer
Copy link
Collaborator

Closes #138

Proposed Changes

  • Now labchart files without time channel are accepted
  • Plus test_txt.py downloads the testing files directly from OSF

@vinferrer vinferrer added Bug Something isn't working Enhancement New feature or request labels Feb 7, 2020
@vinferrer vinferrer self-assigned this Feb 7, 2020
@vinferrer
Copy link
Collaborator Author

Guys, I need to add wget package for the test since I use it to dowload files from OSF, Could you tell me the files i have to modify?

@vinferrer
Copy link
Collaborator Author

solved

@codecov
Copy link

codecov bot commented Feb 7, 2020 •
edited
Loading

Codecov Report

Merging #140 into master will increase coverage by 0.21%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #140      +/-   ##
=========================================
+ Coverage   67.19%   67.4%   +0.21%     
=========================================
  Files          11      11              
  Lines         948     948              
=========================================
+ Hits          637     639       +2     
+ Misses        311     309       -2
Impacted Files Coverage Δ
phys2bids/cli/run.py 19.23% <ø> (ø) ⬆️
phys2bids/tests/test_txt.py 100% <100%> (ø) ⬆️
phys2bids/_version.py 45.12% <0%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20947fb...4f1e4fa. Read the comment docs.

@eurunuela
Copy link
Collaborator

Seeing that the bug in #138 seems to be fixed, is this ready to review @vinferrer ?

@vinferrer vinferrer marked this pull request as ready for review February 9, 2020 08:38
@vinferrer vinferrer requested review from eurunuela and smoia February 9, 2020 08:38
eurunuela
eurunuela requested changes Feb 11, 2020
View reviewed changes
phys2bids/interfaces/txt.py Show resolved Hide resolved
phys2bids/tests/test_txt.py Outdated Show resolved Hide resolved
phys2bids/tests/test_txt.py Show resolved Hide resolved
phys2bids/tests/test_txt.py Show resolved Hide resolved
@vinferrer vinferrer requested a review from eurunuela February 11, 2020 14:34
@vinferrer vinferrer mentioned this pull request Feb 11, 2020
Closed
@eurunuela eurunuela mentioned this pull request Feb 11, 2020
Merged
@vinferrer vinferrer merged commit 72cbb44 into physiopy:master Feb 13, 2020
@vinferrer vinferrer deleted the labchart_no_time branch February 13, 2020 10:52
@smoia smoia added BugFIX This PR generally closes a `Bug` issue, and increments the patch version (0.0.+1) and removed Bug Something isn't working labels Feb 19, 2020
@smoia smoia mentioned this pull request Mar 27, 2020
Merged
2 tasks
@vinferrer vinferrer changed the title Labchart no time add support for labchart files that don't have the time in the channel_list Mar 31, 2020
@vinferrer vinferrer changed the title add support for labchart files that don't have the time in the channel_list Add support for labchart files that don't have the time in the channel_list Mar 31, 2020
@smoia smoia added the released This issue/pull request has been released. label Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoia smoia smoia approved these changes

@eurunuela eurunuela eurunuela approved these changes

Assignees

@vinferrer vinferrer

Labels
BugFIX This PR generally closes a `Bug` issue, and increments the patch version (0.0.+1) Enhancement New feature or request released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when there is no 'time' column (for labchart txt files)
3 participants
@vinferrer @eurunuela @smoia