-
-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the wrong escaping on settings datatable #2100
Conversation
61e3ba7
to
14f3aab
Compare
Signed-off-by: rdwebdesign <github@rdwebdesign.com.br>
b2ac5cb
to
2601675
Compare
Signed-off-by: rdwebdesign <github@rdwebdesign.com.br>
Signed-off-by: rdwebdesign <github@rdwebdesign.com.br>
This should be extended to currently active leases I did not follow the code completely but this looks suspicious as well |
No. The line 601 includes a |
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-ftl-v5-14-web-v5-11-and-core-v5-9-released/53529/1 |
By submitting this pull request, I confirm the following:
git rebase
)git commit --signoff
)What does this PR aim to accomplish?:
Fix #1513
How does this PR accomplish the above?:
The datatable formarter
render: $.fn.dataTable.render.text()
escapes every HTML tag inside the cell, transforming<i>unknown</i>
into<i>unknown</i>
.What documentation changes (if any) are needed to support this PR?:
none