sql-faq: fix outdated description about JDBC #22283
Conversation
Summary of ChangesHello @hfxsd, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the SQL FAQ documentation by correcting and simplifying the explanation of JDBC connection collation behavior. The change aims to provide more accurate and concise information, ensuring that users are directed to the most comprehensive source for details rather than relying on potentially outdated inline examples. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
ti-chi-bot
bot
added
missing-translation-status
hfxsd
added
translation/from-docs-cn
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request improves the clarity of the SQL FAQ regarding JDBC collation by removing a potentially confusing and outdated example. The change simplifies the text and directs readers to the detailed explanation, which is a good improvement. The change is correct and follows documentation best practices.
|
@xhebox: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hfxsd The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
* origin/release-8.5: (48 commits) Terraform: remove `cluster_id` in `cluster_id, vpc_peering_id` (#22318) Update the Compatibility changes of release-8.5.4 (#22233) (#22316) cloud: optimize the description of TiDB-X features (#22294) Add FORMAT keyword to import statement options (#22301) (#22304) cloud: delete disaster recovery (#22299) v8.5.4 tikv: update default settings of `server.grpc-concurrency` and `server.grpc-raft-conn-num`. (#22273) (#22298) Update create-tidb-instance-premium.md (#22288) sync-diff-inspector: add PROCESS permission when upstream and downstream are TiDB (#22289) (#22292) sql-faq: fix outdated description about JDBC (#22283) (#22287) master, v8.5: update download URL from pingcap.org to pingcap.com (#22240) (#22280) tikv: fix the default value of `end-point-memory-quota` (#22271) (#22272) v8.5.4: tikv: update auto compaction config (#22251) (#22265) pdf: update year to 2026 in copyright.tex (#22253) (#22260) v8.5.4 tikv: update rocksdb.max-manifest-file-size default value (#21689) (#22250) tidb-cloud: update the RU definition (#22197) cloud: update backup policies and execution rules (#22227) cloud: add release notes for 20251230 (#22247) cloud: add private link connection docs for overview and Confluent (#22246) tiproxy: add tiproxy usage in the tidb cloud doc (#21483) cloud: update the retention note for the latest automatic backup (#22248) ...
3 participants
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?