Skip to content

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #22233

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added contribution This PR is from a community contributor. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Jan 13, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the documentation for TiDB release 8.5.4, specifically detailing compatibility changes related to system variables and configuration parameters. The changes aim to provide users with a comprehensive understanding of default value modifications, new additions, and deprecations, ensuring a smoother upgrade experience, particularly for clusters with custom performance tuning.

Highlights

  • Documentation Structure Enhancement: The compatibility changes section for TiDB 8.5.4 has been refactored to use a clear table format for both system variables and configuration parameters, improving readability and information accessibility.
  • System Variable Adjustments: The default value of tidb_mpp_store_fail_ttl is now 0s, removing unnecessary delays for new TiFlash nodes. tidb_replica_read now strictly applies to read-only SQL statements, enhancing data safety. Three new system variables (tidb_opt_enable_no_decorrelate_in_select, tidb_opt_enable_semi_join_rewrite, tidb_stats_update_during_ddl) have been introduced to control query optimization and DDL-embedded ANALYZE behavior.
  • Configuration Parameter Updates: TiKV's rocksdb.max-manifest-file-size default increased to 256MiB to mitigate frequent manifest file compactions. TiKV gRPC connection parameters (server.grpc-raft-conn-num, server.grpc-concurrency) now dynamically adapt to CPU core counts for optimized performance. Several legacy TiKV compaction-related parameters have been deprecated and replaced by a new gc.auto-compaction configuration group for better control over automatic compaction. A new TiFlash parameter, flash.graceful_wait_shutdown_timeout, has been added to manage the graceful shutdown process for TiFlash servers.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the compatibility changes for the v8.5.4 release notes. The changes are well-structured, moving from a list to a more readable table format, and include additional details on system variables and configuration parameters. My feedback focuses on minor grammatical and stylistic improvements to enhance clarity and adhere to the documentation style guide, primarily by converting passive voice to active voice.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@hfxsd
Copy link
Collaborator

hfxsd commented Jan 13, 2026

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 13, 2026
@ti-chi-bot ti-chi-bot bot merged commit 7e86681 into pingcap:release-8.5 Jan 13, 2026
8 of 9 checks passed
@ti-chi-bot ti-chi-bot bot deleted the cherry-pick-22233-to-release-8.5 branch January 13, 2026 09:13
breezewish added a commit that referenced this pull request Jan 13, 2026
* origin/release-8.5: (48 commits)
  Terraform: remove `cluster_id` in `cluster_id, vpc_peering_id` (#22318)
  Update the Compatibility changes of release-8.5.4 (#22233) (#22316)
  cloud: optimize the description of TiDB-X features (#22294)
  Add FORMAT keyword to import statement options (#22301) (#22304)
  cloud: delete disaster recovery (#22299)
  v8.5.4 tikv: update default settings of `server.grpc-concurrency` and `server.grpc-raft-conn-num`. (#22273) (#22298)
  Update create-tidb-instance-premium.md (#22288)
  sync-diff-inspector: add PROCESS permission when upstream and downstream are TiDB (#22289) (#22292)
  sql-faq: fix outdated description about JDBC (#22283) (#22287)
  master, v8.5: update download URL from pingcap.org to pingcap.com (#22240) (#22280)
  tikv: fix the default value of `end-point-memory-quota` (#22271) (#22272)
  v8.5.4: tikv: update auto compaction config (#22251) (#22265)
  pdf: update year to 2026 in copyright.tex (#22253) (#22260)
  v8.5.4 tikv: update rocksdb.max-manifest-file-size default value (#21689) (#22250)
  tidb-cloud: update the RU definition (#22197)
  cloud: update backup policies and execution rules (#22227)
  cloud: add release notes for 20251230 (#22247)
  cloud: add private link connection docs for overview and Confluent (#22246)
  tiproxy: add tiproxy usage in the tidb cloud doc (#21483)
  cloud: update the retention note for the latest automatic backup (#22248)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved contribution This PR is from a community contributor. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants