Terraform: cluster_id is not needed in tidbcloud_dedicated_vpc_peering
#22318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
contribution
hfxsd
added
translation/no-need
hfxsd
added
ONCALL
hfxsd
commented
Jan 13, 2026
Oreoxmt
reviewed
Jan 13, 2026
Oreoxmt
reviewed
Jan 13, 2026
Co-authored-by: Aolin <aolinz@outlook.com>
Oreoxmt
approved these changes
Jan 13, 2026
Collaborator
Author
|
/approve |
[LGTM Timeline notifier]Timeline:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hfxsd The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
hfxsd
changed the title
cluster_id in cluster_id, vpc_peering_idcluster_id is not needed in tidbcloud_dedicated_vpc_peering
hfxsd
changed the title
cluster_id is not needed in tidbcloud_dedicated_vpc_peeringcluster_id is not needed in tidbcloud_dedicated_vpc_peering
breezewish
added a commit
that referenced
this pull request
Jan 13, 2026
* origin/release-8.5: (48 commits) Terraform: remove `cluster_id` in `cluster_id, vpc_peering_id` (#22318) Update the Compatibility changes of release-8.5.4 (#22233) (#22316) cloud: optimize the description of TiDB-X features (#22294) Add FORMAT keyword to import statement options (#22301) (#22304) cloud: delete disaster recovery (#22299) v8.5.4 tikv: update default settings of `server.grpc-concurrency` and `server.grpc-raft-conn-num`. (#22273) (#22298) Update create-tidb-instance-premium.md (#22288) sync-diff-inspector: add PROCESS permission when upstream and downstream are TiDB (#22289) (#22292) sql-faq: fix outdated description about JDBC (#22283) (#22287) master, v8.5: update download URL from pingcap.org to pingcap.com (#22240) (#22280) tikv: fix the default value of `end-point-memory-quota` (#22271) (#22272) v8.5.4: tikv: update auto compaction config (#22251) (#22265) pdf: update year to 2026 in copyright.tex (#22253) (#22260) v8.5.4 tikv: update rocksdb.max-manifest-file-size default value (#21689) (#22250) tidb-cloud: update the RU definition (#22197) cloud: update backup policies and execution rules (#22227) cloud: add release notes for 20251230 (#22247) cloud: add private link connection docs for overview and Confluent (#22246) tiproxy: add tiproxy usage in the tidb cloud doc (#21483) cloud: update the retention note for the latest automatic backup (#22248) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?