Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cannot login when use ipv6 address #1516

Merged
merged 4 commits into from
Nov 1, 2023
Merged

Conversation

nexustar
Copy link
Contributor

No description provided.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 20, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • baurine

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@CLAassistant
Copy link

CLAassistant commented Apr 20, 2023

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 24, 2023

@srstack: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

baurine
baurine previously approved these changes Apr 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2023

Codecov Report

Merging #1516 (bd48014) into master (6c0c860) will decrease coverage by 0.01%.
The diff coverage is 12.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1516      +/-   ##
==========================================
- Coverage   24.61%   24.60%   -0.01%     
==========================================
  Files         169      169              
  Lines       15290    15290              
==========================================
- Hits         3763     3762       -1     
- Misses      11245    11246       +1     
  Partials      282      282              
Flag Coverage Δ
backend_integration 9.27% <8.00%> (+0.03%) ⬆️
backend_ut 26.41% <12.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c0c860...bd48014. Read the comment docs.

@netlify
Copy link

netlify bot commented May 11, 2023

Deploy Preview for tidb-dashboard-for-dbaas canceled.

Name Link
🔨 Latest commit 68ec474
🔍 Latest deploy log https://app.netlify.com/sites/tidb-dashboard-for-dbaas/deploys/645c9b001bf51c000923decd

@netlify
Copy link

netlify bot commented May 11, 2023

Deploy Preview for tidb-dashboard failed.

Name Link
🔨 Latest commit bd48014
🔍 Latest deploy log https://app.netlify.com/sites/tidb-dashboard/deploys/6540c52d9abbc60008530736

@baurine baurine added this pull request to the merge queue May 11, 2023
@baurine baurine removed this pull request from the merge queue due to a manual request May 11, 2023
@nexustar
Copy link
Contributor Author

/retest

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 31, 2023

@nexustar: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

ti-chi-bot bot commented Nov 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baurine, srstack

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 1, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 1, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-01 09:41:20.111655723 +0000 UTC m=+3032477.698765861: ☑️ agreed by baurine.

@ti-chi-bot ti-chi-bot bot added the approved label Nov 1, 2023
@ti-chi-bot ti-chi-bot bot merged commit 49fda3d into pingcap:master Nov 1, 2023
9 of 16 checks passed
baurine pushed a commit that referenced this pull request Nov 8, 2023
baurine added a commit that referenced this pull request Nov 8, 2023
* Revert "Release v2023.11.02.1 (#1609)"

This reverts commit 865955c.

* feat(statements): show `plan_cache_hits` field (#1598)

* tweak: make the goroutine profile more verbose (#1450)

* feat: support additional OIDC parameters (#1567)

Co-authored-by: Sparkle <1284531+baurine@users.noreply.github.com>

* chore(sso): improve client secret security (#1599)

* chore(topsql): adjust TopSQL for clinic (#1601)

* chore(sso): support customize OIDC scopes (#1602)

* chore(clinic): support redirect back after login for clinic (#1603)

* chore(topsql): remove username for clinic (#1605)

* chore(topsql): show cluster name and disable auto-refresh for clinic (#1606)

* profiling: Add the support for TiKV heap profiling (#1600)

* increase the upper limit of testing time (#1526)

* fix cannot login when use ipv6 address (#1516)

* tweak: explicitly set session max_execution_time to 600s (#1608)

* profiling: reuse convertDotToSVG to generate tikv heap profile svg (#1610)

* update release version to 2023.11.08.1

---------

Co-authored-by: Yexiang Zhang <mornyx.z@gmail.com>
Co-authored-by: horus <horus.li@gmail.com>
Co-authored-by: Connor <zbk602423539@gmail.com>
Co-authored-by: nexustar <inexustar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants