feat: support additional OIDC parameters #1567
Conversation
✅ Deploy Preview for tidb-dashboard ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
❌ Deploy Preview for tidb-dashboard-for-dbaas failed.
|
|
Welcome @horus! It looks like this is your first PR to pingcap/tidb-dashboard 🎉 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1567 +/- ##
==========================================
- Coverage 24.70% 24.70% -0.01%
==========================================
Files 169 169
Lines 15218 15224 +6
==========================================
+ Hits 3760 3761 +1
- Misses 11176 11181 +5
Partials 282 282
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
|
hi @horus , thanks for your contribution! It will take some time to review and test. |
|
hi @horus , can you sign the CLA? else the CI always fail. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baurine The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
| <Input | ||
| disabled={!isWriteable} | ||
| style={DEFAULT_FORM_ITEM_STYLE} | ||
| /> |
There was a problem hiding this comment.
This should be showed as password, not plain text. I will help refine it later.
There was a problem hiding this comment.
This should be showed as password, not plain text. I will help refine it later.
Yes, you are correct. Thanks for pointing it out.
|
Just signed. |
Co-authored-by: Sparkle <1284531+baurine@users.noreply.github.com>
* Revert "Release v2023.11.02.1 (#1609)" This reverts commit 865955c. * feat(statements): show `plan_cache_hits` field (#1598) * tweak: make the goroutine profile more verbose (#1450) * feat: support additional OIDC parameters (#1567) Co-authored-by: Sparkle <1284531+baurine@users.noreply.github.com> * chore(sso): improve client secret security (#1599) * chore(topsql): adjust TopSQL for clinic (#1601) * chore(sso): support customize OIDC scopes (#1602) * chore(clinic): support redirect back after login for clinic (#1603) * chore(topsql): remove username for clinic (#1605) * chore(topsql): show cluster name and disable auto-refresh for clinic (#1606) * profiling: Add the support for TiKV heap profiling (#1600) * increase the upper limit of testing time (#1526) * fix cannot login when use ipv6 address (#1516) * tweak: explicitly set session max_execution_time to 600s (#1608) * profiling: reuse convertDotToSVG to generate tikv heap profile svg (#1610) * update release version to 2023.11.08.1 --------- Co-authored-by: Yexiang Zhang <mornyx.z@gmail.com> Co-authored-by: horus <horus.li@gmail.com> Co-authored-by: Connor <zbk602423539@gmail.com> Co-authored-by: nexustar <inexustar@gmail.com>
This commit allows some optional parameters to be passed along with the authentication request, including:
...could be a potential solution for the issue reported here.
Thank you!