Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(statements): show plan_cache_hits field #1598

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

baurine
Copy link
Collaborator

@baurine baurine commented Sep 25, 2023

close #1595

Preview

image

image

@netlify
Copy link

netlify bot commented Sep 25, 2023

Deploy Preview for tidb-dashboard ready!

Name Link
🔨 Latest commit 55afb7b
🔍 Latest deploy log https://app.netlify.com/sites/tidb-dashboard/deploys/6512a0d7aef86300089ca0bb
😎 Deploy Preview https://deploy-preview-1598--tidb-dashboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@baurine
Copy link
Collaborator Author

baurine commented Sep 25, 2023

@shhdgit @mornyx , PTAL, thanks~

/cc @qw4990

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 25, 2023

@baurine: GitHub didn't allow me to request PR reviews from the following users: qw4990.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@shhdgit @mornyx , PTAL, thanks~

/cc @qw4990

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #1598 (55afb7b) into master (e11f2b2) will increase coverage by 1.71%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1598      +/-   ##
==========================================
+ Coverage   24.71%   26.42%   +1.71%     
==========================================
  Files         169       97      -72     
  Lines       15218    10452    -4766     
==========================================
- Hits         3761     2762     -999     
+ Misses      11175     7505    -3670     
+ Partials      282      185      -97     
Flag Coverage Δ
backend_integration ?
backend_ut 26.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f677ed...55afb7b. Read the comment docs.

@baurine
Copy link
Collaborator Author

baurine commented Sep 25, 2023

/ok-to-test

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 25, 2023

@baurine: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@baurine
Copy link
Collaborator Author

baurine commented Sep 26, 2023

Need to show in the detail page as well.

@baurine baurine marked this pull request as ready for review September 26, 2023 09:13
@baurine baurine force-pushed the feat/add-plan-cache-hits-field branch from 1bb617b to 55afb7b Compare September 26, 2023 09:13
@baurine baurine changed the title feat(statements): add plan_cache_hits field feat(statements): show plan_cache_hits field Sep 26, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 26, 2023

@mornyx: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@shhdgit shhdgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 27, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 27, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-27 02:14:41.897045712 +0000 UTC m=+413871.615387910: ☑️ agreed by shhdgit.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mornyx, shhdgit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 27, 2023
@ti-chi-bot ti-chi-bot bot merged commit 1c7ef3d into pingcap:master Sep 27, 2023
16 checks passed
@baurine baurine deleted the feat/add-plan-cache-hits-field branch September 27, 2023 02:42
baurine added a commit that referenced this pull request Nov 8, 2023
baurine added a commit that referenced this pull request Nov 8, 2023
* Revert "Release v2023.11.02.1 (#1609)"

This reverts commit 865955c.

* feat(statements): show `plan_cache_hits` field (#1598)

* tweak: make the goroutine profile more verbose (#1450)

* feat: support additional OIDC parameters (#1567)

Co-authored-by: Sparkle <1284531+baurine@users.noreply.github.com>

* chore(sso): improve client secret security (#1599)

* chore(topsql): adjust TopSQL for clinic (#1601)

* chore(sso): support customize OIDC scopes (#1602)

* chore(clinic): support redirect back after login for clinic (#1603)

* chore(topsql): remove username for clinic (#1605)

* chore(topsql): show cluster name and disable auto-refresh for clinic (#1606)

* profiling: Add the support for TiKV heap profiling (#1600)

* increase the upper limit of testing time (#1526)

* fix cannot login when use ipv6 address (#1516)

* tweak: explicitly set session max_execution_time to 600s (#1608)

* profiling: reuse convertDotToSVG to generate tikv heap profile svg (#1610)

* update release version to 2023.11.08.1

---------

Co-authored-by: Yexiang Zhang <mornyx.z@gmail.com>
Co-authored-by: horus <horus.li@gmail.com>
Co-authored-by: Connor <zbk602423539@gmail.com>
Co-authored-by: nexustar <inexustar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show PLAN_CACHE_HITS field on the SQL statements page
3 participants