-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(statements): show plan_cache_hits
field
#1598
feat(statements): show plan_cache_hits
field
#1598
Conversation
✅ Deploy Preview for tidb-dashboard ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@baurine: GitHub didn't allow me to request PR reviews from the following users: qw4990. Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1598 +/- ##
==========================================
+ Coverage 24.71% 26.42% +1.71%
==========================================
Files 169 97 -72
Lines 15218 10452 -4766
==========================================
- Hits 3761 2762 -999
+ Misses 11175 7505 -3670
+ Partials 282 185 -97
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
/ok-to-test |
@baurine: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Need to show in the detail page as well. |
1bb617b
to
55afb7b
Compare
plan_cache_hits
fieldplan_cache_hits
field
@mornyx: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mornyx, shhdgit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Revert "Release v2023.11.02.1 (#1609)" This reverts commit 865955c. * feat(statements): show `plan_cache_hits` field (#1598) * tweak: make the goroutine profile more verbose (#1450) * feat: support additional OIDC parameters (#1567) Co-authored-by: Sparkle <1284531+baurine@users.noreply.github.com> * chore(sso): improve client secret security (#1599) * chore(topsql): adjust TopSQL for clinic (#1601) * chore(sso): support customize OIDC scopes (#1602) * chore(clinic): support redirect back after login for clinic (#1603) * chore(topsql): remove username for clinic (#1605) * chore(topsql): show cluster name and disable auto-refresh for clinic (#1606) * profiling: Add the support for TiKV heap profiling (#1600) * increase the upper limit of testing time (#1526) * fix cannot login when use ipv6 address (#1516) * tweak: explicitly set session max_execution_time to 600s (#1608) * profiling: reuse convertDotToSVG to generate tikv heap profile svg (#1610) * update release version to 2023.11.08.1 --------- Co-authored-by: Yexiang Zhang <mornyx.z@gmail.com> Co-authored-by: horus <horus.li@gmail.com> Co-authored-by: Connor <zbk602423539@gmail.com> Co-authored-by: nexustar <inexustar@gmail.com>
close #1595
Preview