br: support ebs snapshot #4698
br: support ebs snapshot #4698
Conversation
Support BR on Azure Blob Storage
|
/test pull-e2e-kind-across-kubernetes |
|
/test pull-e2e-kind |
| @@ -663,6 +679,19 @@ func canSkipSetGCLifeTime(image string) bool { | |||
| return true | |||
| } | |||
|
|
|||
| func BytesToString(b []byte) string { | |||
There was a problem hiding this comment.
| func BytesToString(b []byte) string { | |
| func BytesToStringWithoutAllocation(b []byte) string { |
Maybe declaring the meaning of this function in name is better? Or it is hard to understand.
There was a problem hiding this comment.
I doubt if we really need to do this hack to improve performance while it's not used in hot path. cc @fengou1
|
@WizardXiao: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
@fengou1: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
@WangLe1321: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/merge |
|
@csuzhangxc: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/test pull-e2e-kind |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: d12420c
|
What problem does this PR solve?
What is changed and how does it work?
Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.