Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ebs br: add create pv permissions to operator (#5314) #5317

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5314

What problem does this PR solve?

TiDB operator needs permissions to create PV during restore operations. Previously this was added by #4698, however that PR missed adding the permissions to the non-cluster-scoped part of the template. This PR fixes this by adding the permission for non cluster scoped manifests.

What is changed and how does it work?

Add create PV permissions to non-cluster scoped operator manifest templates.

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@BornChanger
Copy link
Contributor

/test pull-e2e-kind-br

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 29, 2023

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@release-1.5

In response to this:

/test pull-e2e-kind-br

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 29, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 29, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-29 14:17:56.578162324 +0000 UTC m=+197874.165272469: ☑️ agreed by BornChanger.

@ti-chi-bot ti-chi-bot bot added the approved label Sep 29, 2023
@BornChanger
Copy link
Contributor

/test pull-e2e-kind-br

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 29, 2023

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@release-1.5

In response to this:

/test pull-e2e-kind-br

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BornChanger
Copy link
Contributor

/test pull-e2e-kind-br

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 29, 2023

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@release-1.5

In response to this:

/test pull-e2e-kind-br

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BornChanger
Copy link
Contributor

/retest

@codecov-commenter
Copy link

Codecov Report

Merging #5317 (765d902) into release-1.5 (4e1ca0c) will increase coverage by 0.12%.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.5    #5317      +/-   ##
===============================================
+ Coverage        57.63%   57.75%   +0.12%     
===============================================
  Files              254      258       +4     
  Lines            30827    34457    +3630     
===============================================
+ Hits             17768    19902    +2134     
- Misses           11319    12721    +1402     
- Partials          1740     1834      +94     
Flag Coverage Δ
e2e 21.45% <ø> (?)
unittest 57.65% <ø> (+0.01%) ⬆️

@csuzhangxc csuzhangxc merged commit c320849 into pingcap:release-1.5 Sep 29, 2023
6 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants