-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ebs br: add create pv permissions to operator #5314
ebs br: add create pv permissions to operator #5314
Conversation
Welcome @larat7! It looks like this is your first PR to pingcap/tidb-operator 🎉 |
3599193
to
88426d0
Compare
/cc @WangLe1321 |
/cc @BornChanger |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5314 +/- ##
==========================================
+ Coverage 57.66% 60.23% +2.57%
==========================================
Files 252 255 +3
Lines 30810 34332 +3522
==========================================
+ Hits 17766 20680 +2914
- Misses 11301 11794 +493
- Partials 1743 1858 +115
|
@larat7: Your PR was out of date, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/retest |
/cherry-pick release-1.5 |
@BornChanger: once the present PR merges, I will cherry-pick it on top of release-1.5 in the new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, WangLe1321 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
@BornChanger: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
TiDB operator needs permissions to create PV during restore operations. Previously this was added by #4698, however that PR missed adding the permissions to the non-cluster-scoped part of the template. This PR fixes this by adding the permission for non cluster scoped manifests.
What is changed and how does it work?
Add
create
PV permissions to non-cluster scoped operator manifest templates.Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.