Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ebs br: add create pv permissions to operator #5314

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

larat7
Copy link
Contributor

@larat7 larat7 commented Sep 28, 2023

What problem does this PR solve?

TiDB operator needs permissions to create PV during restore operations. Previously this was added by #4698, however that PR missed adding the permissions to the non-cluster-scoped part of the template. This PR fixes this by adding the permission for non cluster scoped manifests.

What is changed and how does it work?

Add create PV permissions to non-cluster scoped operator manifest templates.

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 28, 2023

Welcome @larat7! It looks like this is your first PR to pingcap/tidb-operator 🎉

@sre-bot
Copy link
Contributor

sre-bot commented Sep 28, 2023

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added the size/XS label Sep 28, 2023
@BornChanger
Copy link
Contributor

/cc @WangLe1321

@BornChanger
Copy link
Contributor

/cc @BornChanger

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2023

Codecov Report

Merging #5314 (5e6f7db) into master (2ebd0fe) will increase coverage by 2.57%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5314      +/-   ##
==========================================
+ Coverage   57.66%   60.23%   +2.57%     
==========================================
  Files         252      255       +3     
  Lines       30810    34332    +3522     
==========================================
+ Hits        17766    20680    +2914     
- Misses      11301    11794     +493     
- Partials     1743     1858     +115     
Flag Coverage Δ
e2e 30.78% <ø> (?)
unittest 57.65% <ø> (-0.01%) ⬇️

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 29, 2023

@larat7: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot removed the lgtm label Sep 29, 2023
@BornChanger
Copy link
Contributor

/retest

@BornChanger
Copy link
Contributor

/cherry-pick release-1.5

@ti-chi-bot
Copy link
Member

@BornChanger: once the present PR merges, I will cherry-pick it on top of release-1.5 in the new PR and assign it to you.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 29, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, WangLe1321

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [BornChanger,WangLe1321]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 29, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-29 06:28:57.829991617 +0000 UTC m=+169735.417101759: ☑️ agreed by WangLe1321.
  • 2023-09-29 06:48:55.857287352 +0000 UTC m=+170933.444397482: ✖️🔁 reset by ti-chi-bot[bot].
  • 2023-09-29 12:04:03.512550176 +0000 UTC m=+189841.099660320: ☑️ agreed by BornChanger.

@csuzhangxc csuzhangxc merged commit 210591e into pingcap:master Sep 29, 2023
9 of 13 checks passed
@ti-chi-bot
Copy link
Member

@BornChanger: new pull request created to branch release-1.5: #5317.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants